Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Keyboard navigation doesn't work with search-enabled="false" #375

Closed
mihaic-gf opened this issue Nov 5, 2014 · 17 comments · Fixed by #1717
Closed

Keyboard navigation doesn't work with search-enabled="false" #375

mihaic-gf opened this issue Nov 5, 2014 · 17 comments · Fixed by #1717
Assignees
@user378230
Labels
PRs plz! type: bug

Comments

@mihaic-gf
Copy link

Hello,

Great job with this project, I have only one small problem, if I add search-enabled="false" when I have few options, keyboard navigation doesn't work anymore. Is there any other way to hide search field?

Example:
ui-select ng-model="person.selected" theme="select2" ng-disabled="disabled" search-enabled="false" style="min-width: 300px;"

Best Regards,
Mihai
@zzal
Copy link

zzal commented Nov 28, 2014

+1

3 similar comments
@davideanderson
Copy link

+1

@jonsonjonson
Copy link

+1

@mareczek
Copy link
Contributor

+1

@dimirc dimirc added this to the 0.11.x milestone Mar 11, 2015
@kleyy
Copy link

kleyy commented Mar 12, 2015

+1

5 similar comments
@uschmann
Copy link

+1

@brentmiller
Copy link

+1

@seinavco
Copy link

+1

@akashta
Copy link

akashta commented Jul 10, 2015

+1

@chloe-pellen
Copy link

+1

@LFDM
Copy link

LFDM commented Sep 21, 2015

Is there any progress on this?

@chloe-pellen
Copy link

:/ ????

@progmars
Copy link

+1
(many times).

This is the only issue which made our UI testers angry. Keyboard navigation is a must, especially in enterprise applications where system operators often navigate forms only using keyboard because that's much faster.

As far as I have seen, ui-select is the most popular (68 contributors!) dropdown element for Angular, but this issue is real showstopper. Maybe I'll find some time to fix it myself, but more likely, I'll find some other dropdown, maybe less popular (and less supported) but with keyboard navigation. Which is a shame, because otherwise ui-select is great.

@wesleycho wesleycho removed this from the 0.11.x milestone Mar 27, 2016
@fcaballero
Copy link

@wesleycho there are already some PR that can solve this issue; PR1114 and PR1109. I had the same idea and I think is the most cleanest way as the searchInput already has the keyboard navigation handler.
@cbryer and @cdjackson may you let us know whether those PR are ready to merge?

@user378230
Copy link
Contributor

#1114 looks the more comprehensive of the two, @fcaballero if you feel strongly you could fork cbryer's repo, rebase, resolve any conflicts, squash and create a new PR?

@fcaballero
Copy link

@user378230 ok for me, I will take care of it ;)

fcaballero added a commit to fcaballero/ui-select that referenced this issue Mar 30, 2016
@fcaballero
fix(search-enabled) keyboard navigation does not work when search-ena…
ac0c72f 
…bled is false

Closes angular-ui#375 PRs angular-ui#1114 and angular-ui#1109
@fcaballero fcaballero mentioned this issue Mar 30, 2016
Closed
@fcaballero
Copy link

@user378230 or @wesleycho may you please merge these changes in #1543 and remove the oldest PRs?

fcaballero added a commit to fcaballero/ui-select that referenced this issue Apr 25, 2016
@fcaballero
fix(search-enabled) keyboard navigation does not work when search-ena…
ff4818b 
…bled is false

Closes angular-ui#375 PRs angular-ui#1114 and angular-ui#1109

fix(indentation)  use 2 spaces, add white-space
@user378230 user378230 self-assigned this Jul 10, 2016
user378230 pushed a commit to user378230/ui-select that referenced this issue Jul 10, 2016
@cbryer @user378230
fix(searchEnabled): maintain keyboard nagivation
b5cc902 
Fix issue where keyboard navigation was disabled when searchEnabled
was set to false.

Caused by hiding the input box which prevent key events from
propagating to the directive.

Resolved hiding the input offscreen when searchEnabled is false.

Fixes angular-ui#1059, fixes angular-ui#917, fixes angular-ui#589, fixes angular-ui#375
Closes angular-ui#1543, closes angular-ui#1114, closes angular-ui#1109 (supersedes all)
@user378230 user378230 mentioned this issue Jul 10, 2016
Merged
aaronroberson pushed a commit that referenced this issue Aug 7, 2016
@user378230 @aaronroberson
Fix numerous issues with select enabled (#1717)
be0d301 
* fix(searchEnabled): maintain keyboard nagivation

Fix issue where keyboard navigation was disabled when searchEnabled
was set to false.

Caused by hiding the input box which prevent key events from
propagating to the directive.

Resolved hiding the input offscreen when searchEnabled is false.

Fixes #1059, fixes #917, fixes #589, fixes #375
Closes #1543, closes #1114, closes #1109 (supersedes all)

* fix(selectize): show placeholder when search disabled

Previously when searchEnabled was set to false, the placeholder would
also be hidden on the selectize theme.

This fix sets the search input to disabled rather then hidden when the
searchEnabled attribute is set to false.

Fixes #1145, fixes #949, fixes #691

* fix(searchEnabled): Prevent searching when disabled

Previously, even when search-enabled was set to false, users could
still type in text and filter the list. This made disabling the search
feature pointless.

This fix prevents text entry to the search input and thus disables
filtering.

Fixes #1658
kboga pushed a commit to kboga/ui-select that referenced this issue Nov 29, 2016
@user378230
Fix numerous issues with select enabled (angular-ui#1717)
183c2d6 
* fix(searchEnabled): maintain keyboard nagivation

Fix issue where keyboard navigation was disabled when searchEnabled
was set to false.

Caused by hiding the input box which prevent key events from
propagating to the directive.

Resolved hiding the input offscreen when searchEnabled is false.

Fixes angular-ui#1059, fixes angular-ui#917, fixes angular-ui#589, fixes angular-ui#375
Closes angular-ui#1543, closes angular-ui#1114, closes angular-ui#1109 (supersedes all)

* fix(selectize): show placeholder when search disabled

Previously when searchEnabled was set to false, the placeholder would
also be hidden on the selectize theme.

This fix sets the search input to disabled rather then hidden when the
searchEnabled attribute is set to false.

Fixes angular-ui#1145, fixes angular-ui#949, fixes angular-ui#691

* fix(searchEnabled): Prevent searching when disabled

Previously, even when search-enabled was set to false, users could
still type in text and filter the list. This made disabling the search
feature pointless.

This fix prevents text entry to the search input and thus disables
filtering.

Fixes angular-ui#1658
@daerogami daerogami mentioned this issue Oct 5, 2017
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@user378230 user378230

Labels
PRs plz! type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix numerous issues with select enabled user378230/ui-select