Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Pleaceholder is not visible when search-enabled is false #1145

Closed
AndrewEastwood opened this issue Aug 13, 2015 · 7 comments · Fixed by #1717
Closed

Pleaceholder is not visible when search-enabled is false #1145

AndrewEastwood opened this issue Aug 13, 2015 · 7 comments · Fixed by #1717
Assignees

Comments

@AndrewEastwood
Copy link

How to show placeholder for regular mode of select?

@bliitzkrieg
Copy link

@AndrewEastwood did u find a fix?

@AndrewEastwood
Copy link
Author

I'll try and let you know later

@chielsen
Copy link

chielsen commented Dec 9, 2015

I have the same problem

@AndrewEastwood
Copy link
Author

Guys, I've just dropped this buggy lib out from my project and switched to select2

@hkorutla
Copy link

Did you find any fix?

@hkorutla
Copy link

I have the same problem with "selectize" theme.

@wesleycho
Copy link
Contributor

This needs a reproduction via Plunker.

@user378230 user378230 self-assigned this Jul 10, 2016
user378230 added a commit to user378230/ui-select that referenced this issue Jul 10, 2016
Previously when searchEnabled was set to false, the placeholder would
also be hidden on the selectize theme.

This fix sets the search input to disabled rather then hidden when the
searchEnabled attribute is set to false.

Fixes angular-ui#1145, fixes angular-ui#949, fixes angular-ui#691
aaronroberson pushed a commit that referenced this issue Aug 7, 2016
* fix(searchEnabled): maintain keyboard nagivation

Fix issue where keyboard navigation was disabled when searchEnabled
was set to false.

Caused by hiding the input box which prevent key events from
propagating to the directive.

Resolved hiding the input offscreen when searchEnabled is false.

Fixes #1059, fixes #917, fixes #589, fixes #375
Closes #1543, closes #1114, closes #1109 (supersedes all)

* fix(selectize): show placeholder when search disabled

Previously when searchEnabled was set to false, the placeholder would
also be hidden on the selectize theme.

This fix sets the search input to disabled rather then hidden when the
searchEnabled attribute is set to false.

Fixes #1145, fixes #949, fixes #691

* fix(searchEnabled): Prevent searching when disabled

Previously, even when search-enabled was set to false, users could
still type in text and filter the list. This made disabling the search
feature pointless.

This fix prevents text entry to the search input and thus disables
filtering.

Fixes #1658
kboga pushed a commit to kboga/ui-select that referenced this issue Nov 29, 2016
* fix(searchEnabled): maintain keyboard nagivation

Fix issue where keyboard navigation was disabled when searchEnabled
was set to false.

Caused by hiding the input box which prevent key events from
propagating to the directive.

Resolved hiding the input offscreen when searchEnabled is false.

Fixes angular-ui#1059, fixes angular-ui#917, fixes angular-ui#589, fixes angular-ui#375
Closes angular-ui#1543, closes angular-ui#1114, closes angular-ui#1109 (supersedes all)

* fix(selectize): show placeholder when search disabled

Previously when searchEnabled was set to false, the placeholder would
also be hidden on the selectize theme.

This fix sets the search input to disabled rather then hidden when the
searchEnabled attribute is set to false.

Fixes angular-ui#1145, fixes angular-ui#949, fixes angular-ui#691

* fix(searchEnabled): Prevent searching when disabled

Previously, even when search-enabled was set to false, users could
still type in text and filter the list. This made disabling the search
feature pointless.

This fix prevents text entry to the search input and thus disables
filtering.

Fixes angular-ui#1658
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants