Breaks with angular 1.5-rc.0 #1356
Comments
|
same with me |
|
this is worked for me |
|
i have same issue works with 1.5.0-beta.0 but not rc-0 |
|
According angular/angular.js#13527, they don't plan to change this behaviour so ui-select should adapt i think |
|
@aaronroberson I see you are now a major contributor to this project! This issue must indeed be fixed by ui-select. See this thread for more info on reasons and a possible fix: angular/angular.js#13527 You can also ping me if you have questions. |
|
@Narretz I've reviewed the issue you linked. Is there a PR for this? |
|
Seems to me like with 1.5's new multiple transclusion feature, the transclusion mechanics of ui-select could be vastly simplified anyway. |
|
@aaronroberson There's no PR yet. I've worked on a fix for ui-select a while back, but I abandoned it because the test suite wqs broken. I'll check if I still have it. |
|
Given that this is a duplicate of #1325, would it make sense to close this and focus discussion on the other issue? |
|
A PR is needed! On Sun, Feb 7, 2016, 5:40 PM Chris Foster notifications@github.com wrote:
|
In Angular 1.5, transcluded content is linked lazily. For uiSelect that means the clone in the transclude function is not compiled and linked yet, so uiSelect cannot detect the match and choices elements by their classnames, because they haven't been set yet (which happens by replacing the elements with the templates). However, the templateUrl function is executed at this point, so we can use it to add the class names to the directive elements. On another note, this behavior also affected versions earlier than 1.5.0-beta.2, when the template of ui-select-match or ui-select-choices wasn't cached. In that case, the async compilation of the template would mean also that the clone in the transclude function wasn't compiled yet, and so the classes wouldn't be set either. Closes angular-ui#1422 Closes angular-ui#1356 Closes angular-ui#1325 Closes angular-ui#1239
|
PR is here: #1430 |
In Angular 1.5, transcluded content is compiled lazily. For uiSelect that means the clone in the transclude function is not compiled and linked yet, so uiSelect cannot detect the match and choices elements by their classnames, because they haven't been set yet (which happens by replacing the elements with the templates). However, the templateUrl function is executed at this point, so we can use it to add the class names to the directive elements. On another note, this behavior also affected versions earlier than 1.5.0-beta.2, when the template of ui-select-match or ui-select-choices wasn't cached. In that case, the async compilation of the template would mean also that the clone in the transclude function wasn't compiled yet, and so the classes wouldn't be set either. This might be the cause of the error described in issue angular-ui#224. Closes angular-ui#1422 Closes angular-ui#1356 Closes angular-ui#1325 Closes angular-ui#1239
|
@aaronroberson You, uh, might want to change your email password 😬 |
|
Oh wow, this is getting posted all over Github. Fun times. I've deleted the posts here, thanks! |
|
@aaronroberson Still happening |
|
Can someone lock this issue? Maybe they just stole his contacts and are spoofing his account, nothing he can do. @aaronroberson I hope you're aware it's still happening |
|
Ahhhhhhh. I removed the third-party app from my Google settings but to no avail. I contact their customer support and they said to click the unsubscribe link in the post. I've done that, hopefully it doesn't happen again. My sincere appologies! |
|
@aaronroberson Unfortunately I think that anyone who has obtained the specific address for this issue thread can reply. I'm not sure how github identifies it as you but likely something a spammer can spoof. Meaning once they stole your contacts, the damage was done. Maybe you can change the email you use with github or contact them for advice. But it also means they may be spamming others from your list. |
|
I thinkn clicking unsubscribe fixed it! |
The text was updated successfully, but these errors were encountered: