This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(dropdown): cross browser dropdown position #1212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 28, 2015
@ramdog I cannot reproduce it. I just scrolled until red field is at bottom and then tried to open dropdown but I see it showing above correctly. In what browser did your tried? Can you explain me better how to reproduce it? |
Hey @dimirc, it does open correctly, but from your screenshots it looks like you may have missed the last step in testing.
|
dimirc
force-pushed
the
fix-dropdown-pos
branch
from
September 28, 2015 22:48
29ce97d
to
f98b050
Compare
@ramdog got it. Pls recheck the corrected demo and it should be working correctly now |
Looks great, nice work! |
Nice. It's working. |
dimirc
added a commit
that referenced
this pull request
Sep 29, 2015
fix(dropdown): cross browser dropdown position
Nice work. Is their also the intention to make this work in the directions left and right? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid incorrect dropdown position
Wrong Demo
Corrected Demo
To reproduce, scroll down to red field