Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

fix(dropdown): cross browser dropdown position #1212

Merged
merged 1 commit into from
Sep 29, 2015
Merged

Conversation

dimirc
Copy link
Contributor

@dimirc dimirc commented Sep 28, 2015

To avoid incorrect dropdown position

Wrong Demo

Corrected Demo

To reproduce, scroll down to red field

@ramdog
Copy link

ramdog commented Sep 28, 2015

Hey, nice work. Indeed this looks good in the case where the dropdown has room below:
image

However, it seems the case where the dropdown is opening above, this is still an issue (to reproduce, scroll down so that the red field is just above the bottom then type in admin2):
image

@dimirc
Copy link
Contributor Author

dimirc commented Sep 28, 2015

@ramdog I cannot reproduce it. I just scrolled until red field is at bottom and then tried to open dropdown but I see it showing above correctly. In what browser did your tried? Can you explain me better how to reproduce it?

Chrome
image

Firefox
image

@ramdog
Copy link

ramdog commented Sep 28, 2015

Hey @dimirc, it does open correctly, but from your screenshots it looks like you may have missed the last step in testing.

  1. Do exactly what you did (scroll down just enough to force the dropdown to open up).
  2. Then type out admin2 - the whole thing. Notice the Admin2 option is indeed selected but still floating way up. Instead, it should be just above the search input.

@dimirc
Copy link
Contributor Author

dimirc commented Sep 28, 2015

@ramdog got it. Pls recheck the corrected demo and it should be working correctly now

@ramdog
Copy link

ramdog commented Sep 29, 2015

Looks great, nice work!
👍

@estevaolucasold
Copy link

Nice. It's working.

dimirc added a commit that referenced this pull request Sep 29, 2015
fix(dropdown): cross browser dropdown position
@dimirc dimirc merged commit 15920e4 into master Sep 29, 2015
@dimirc dimirc deleted the fix-dropdown-pos branch September 29, 2015 16:48
@GitHubUserNameX
Copy link

Nice work. Is their also the intention to make this work in the directions left and right?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants