fix(spinner-class): add glyphicon to default spinner class, update css #1894

brianchance · 2017-01-25T20:55:20Z

Fixes #1893.

Jefiozie · 2017-01-26T07:09:48Z

@brianchance , can you have a look at the build error's?
Thanks

brianchance · 2017-01-27T16:59:27Z

Done.

Jefiozie · 2017-01-30T06:50:02Z

src/common.css

@@ -317,17 +317,10 @@ body > .ui-select-bootstrap.open {
 }

 /* Spinner */
-.ui-select-refreshing {
+.ui-select-refreshing.glyphicon {


Should the ui-select-refreshing.glyphicon be as one selector?

brianchance · 2017-01-30T13:39:48Z

I did it this way so you can target font-awesome with .ui-select-refreshing.fa. It needs different positioning.

brianchance · 2017-01-30T22:20:53Z

For font-awesome, I am using...

.ui-select-refreshing.fa {
  position: absolute;
  top: 9px;
  right: 27px;
 }

Jefiozie · 2017-03-07T06:45:13Z

Merged it thanks.

fix(spinner-class): add glyphicon to default spinner class, update css.

c8f69db

Fixes #1893.

fix(select-spinner): fix spec test

2d62e0b

Jefiozie reviewed Jan 30, 2017

View reviewed changes

Jefiozie approved these changes Mar 7, 2017

View reviewed changes

Jefiozie merged commit 3e25a48 into angular-ui:master Mar 7, 2017

Provide feedback