Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Fixed undesired submit action #503

Closed
wants to merge 1 commit into from

Conversation

andaviaco
Copy link

If you use ui-select inside a form, the form gets submitted when you click the 'caret' button, by adding a type in the button it prevents this behavior :3.
tested in Chrome v.38.0.2125.122 using AngularJS v.1.2.27

If you use ui-select inside a form, the form gets submitted when you click the 'caret' button, by adding a type in the button it prevents this behavior :3.
tested in Chrome v.38.0.2125.122 using AngularJS v.1.2.27
@dimirc dimirc added the unknown label Dec 12, 2014
@CesarLanderos
Copy link

yep :/, that's correct

@brianfeister
Copy link

Covered by this PR which is more likely to be merged: #537

@dimirc dimirc removed the unknown label Dec 19, 2014
@brianfeister brianfeister mentioned this pull request Dec 19, 2014
@CesarLanderos
Copy link

@brianfeister not really, the second button doesnt have a type:

<button class="ui-select-clear" ng-if="$select.allowClear && !$select.isEmpty()" ng-click="$select.select(undefined)">
    <i class="glyphicon glyphicon-remove"></i>
</button>

@brianfeister brianfeister reopened this Jan 12, 2015
brianfeister pushed a commit that referenced this pull request Jan 12, 2015
@brianfeister
Copy link

Fix released in v0.9.6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants