This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
fix for #282 #547
Closed
fix for #282 #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is caused by the inproperly triggered 'mouseenter' event when scrolling happens.
To fix this issue, we need to capture the event and prevent it from propagating if it is triggered by a scroll (which is handled by the _ensureHighlightVisible function call ).
Due to the fact that mouseenter event is triggered differently than normal dom events that bubbles, see: https://developer.mozilla.org/en-US/docs/Web/Events/mouseenter, changing ng-mouseenter to ng-mouseover would enable as to capture the mouseover event and prevent it from propagating.