This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Move search box off screen when clicked and searchDisabled #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that the search boxes are not hidden when in !searchEnabled and they are clicked. This ensures that they can still receive focus and react to keyboard events. This addresses issue angular-ui#331.
|
+1 will this be merged? |
|
Closing as I believe this has been superseded by a different PR that has been merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the search boxes are not hidden
when in !searchEnabled and they are clicked. This
ensures that they can still receive focus and react to
keyboard events. This addresses issue #331.
I'm not super happy with this change since it feels a bit
odd to move elements offscreen in order to ensure they
can still receive focus. Suggestions on improvement are
welcome.