add --inline-client command option to customize inline client URL for…

… livereload in webpack-dev-server
angular · Dec 4, 2016 · 0223193 · 0223193
1 parent 457a6e0
commit 0223193
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/packages/angular-cli/commands/serve.ts b/packages/angular-cli/commands/serve.ts
@@ -32,6 +32,7 @@ export interface ServeTaskOptions {
   open?: boolean;
   vendorChunk?: boolean;
   hmr?: boolean;
+  inlineClient?: string;
 }
 
 const ServeCommand = Command.extend({
@@ -103,6 +104,12 @@ const ServeCommand = Command.extend({
       default: false,
       description: 'Enable hot module replacement',
     },
+    {
+      name: 'inline-client',
+      type: String,
+      aliases: ['ic'],
+      description: '(Defaults to "http://host:port")'
+    }
   ],
 
   run: function(commandOptions: ServeTaskOptions) {
@@ -117,6 +124,9 @@ const ServeCommand = Command.extend({
 
     commandOptions.liveReloadHost = commandOptions.liveReloadHost || commandOptions.host;
 
+    commandOptions.inlineClient = commandOptions.inlineClient ||
+      `http://${commandOptions.host}:${commandOptions.port}/`;
+
     return this._checkExpressPort(commandOptions)
       .then(this._autoFindLiveReloadPort.bind(this))
       .then((opts: ServeTaskOptions) => {

diff --git a/packages/angular-cli/tasks/serve-webpack.ts b/packages/angular-cli/tasks/serve-webpack.ts
@@ -35,8 +35,9 @@ export default Task.extend({
     // This allows for live reload of page when changes are made to repo.
     // https://webpack.github.io/docs/webpack-dev-server.html#inline-mode
     let entryPoints = [
-      `webpack-dev-server/client?http://${serveTaskOptions.host}:${serveTaskOptions.port}/`
+      `webpack-dev-server/client?${serveTaskOptions.inlineClient}/`
     ];
+
     if (serveTaskOptions.hmr) {
       const webpackHmrLink = 'https://webpack.github.io/docs/hot-module-replacement.html';
       ui.writeLine(oneLine`