fix(@angular-devkit/build-angular): print server builder errors and w…

…arnings

Previously server builder errors and warnings were not being printed in the console correctly.

Closes #24612

(cherry picked from commit f35e990)

packages/angular_devkit/build_angular/src/builders/server/index.ts

@@ -33,7 +33,13 @@ import {
 } from '../../utils/webpack-browser-config';
 import { getCommonConfig, getStylesConfig } from '../../webpack/configs';
 import { isPlatformServerInstalled } from '../../webpack/utils/helpers';
-import { webpackStatsLogger } from '../../webpack/utils/stats';
+import {
+  statsErrorsToString,
+  statsHasErrors,
+  statsHasWarnings,
+  statsWarningsToString,
+  webpackStatsLogger,
+} from '../../webpack/utils/stats';
 import { Schema as ServerBuilderOptions } from './schema';
 
 /**
@@ -87,12 +93,19 @@ export function execute(
         },
       }).pipe(
         concatMap(async (output) => {
-          const { emittedFiles = [], outputPath, webpackStats } = output;
+          const { emittedFiles = [], outputPath, webpackStats, success } = output;
           if (!webpackStats) {
             throw new Error('Webpack stats build result is required.');
           }
 
-          if (!output.success) {
+          if (!success) {
+            if (statsHasWarnings(webpackStats)) {
+              context.logger.warn(statsWarningsToString(webpackStats, { colors: true }));
+            }
+            if (statsHasErrors(webpackStats)) {
+              context.logger.error(statsErrorsToString(webpackStats, { colors: true }));
+            }
+
             return output;
           }
 

packages/angular_devkit/build_angular/src/builders/server/tests/behavior/build-errors_spec.ts

@@ -0,0 +1,34 @@
+/**
+ * @license
+ * Copyright Google LLC All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+
+import { logging } from '@angular-devkit/core';
+import { execute } from '../../index';
+import { BASE_OPTIONS, SERVER_BUILDER_INFO, describeBuilder } from '../setup';
+
+describeBuilder(execute, SERVER_BUILDER_INFO, (harness) => {
+  describe('Behavior: "Build Error"', () => {
+    it('emits errors', async () => {
+      harness.useTarget('server', {
+        ...BASE_OPTIONS,
+        watch: true,
+      });
+
+      // Generate an error
+      await harness.appendToFile('src/main.server.ts', `const foo: = 'abc';`);
+
+      const { result, logs } = await harness.executeOnce();
+
+      expect(result?.success).toBeFalse();
+      expect(logs).toContain(
+        jasmine.objectContaining<logging.LogEntry>({
+          message: jasmine.stringMatching(/TS1110:.*Type expected/),
+        }),
+      );
+    });
+  });
+});

packages/angular_devkit/build_angular/src/builders/server/tests/behavior/web-workers_spec.ts

@@ -12,14 +12,14 @@ import { BASE_OPTIONS, SERVER_BUILDER_INFO, describeBuilder } from '../setup';
 describeBuilder(execute, SERVER_BUILDER_INFO, (harness) => {
   describe('Behavior: "Errors"', () => {
     it('should not try to resolve web-workers', async () => {
-      harness.useTarget('test', {
+      harness.useTarget('server', {
         ...BASE_OPTIONS,
       });
 
       await harness.writeFiles({
         'src/app/app.worker.ts': `
           /// <reference lib="webworker" />
-  
+
           const foo: string = 'hello world';
           addEventListener('message', ({ data }) => {
             postMessage(foo);