-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema validation fails when replacing .mts
file with another one
#27124
Comments
demurgos
added a commit
to demurgos/angular-cli
that referenced
this issue
Feb 17, 2024
This commit updates the `fileReplacement` pattern to allow `.mts` and `.cts` files. Closes angular#27124
demurgos
added a commit
to demurgos/angular-cli
that referenced
this issue
Feb 17, 2024
…ement Updates the `fileReplacement` pattern to allow `.mts` and `.cts` files. This enables support for TypeScript files with explicit ESM support. Closes angular#27124
13 tasks
dgp1130
pushed a commit
to demurgos/angular-cli
that referenced
this issue
Feb 21, 2024
…ement Updates the `fileReplacement` pattern to allow `.mts` and `.cts` files. This enables support for TypeScript files with explicit ESM support. Closes angular#27124
dgp1130
pushed a commit
that referenced
this issue
Feb 21, 2024
…ement Updates the `fileReplacement` pattern to allow `.mts` and `.cts` files. This enables support for TypeScript files with explicit ESM support. Closes #27124
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Command
build, serve
Is this a regression?
The previous version in which this bug was not present was
No response
Description
I have an Angular 17 project using
.mts
files. It's working perfectly, both withng build
andng serve
. It uses the@angular-devkit/build-angular:application
builder. To support a new feature, I needed to swap a file when running the live-reload mode withng serve
. Following the documentation forfileReplacements
, I added:I now get the following error when running
ng serve
:The regex pattern does not match what builds without replacement are actually using. Regular builds support
"\.(([cm]?[jt])sx?|json)$"
. However, the pattern itself is questionable: why even limit the file extensions here? I don't need it right now, but what if I wanted to swap a.wasm
file or any other kind of file? If a regular build works, adding a file replacement rule should never restrict it more.Minimal Reproduction
Add a file replacement rule targeting an
mts
file. Example:Run the corresponding command (
ng build
,ng serve
)Exception or Error
The text was updated successfully, but these errors were encountered: