Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page reload extremely slow #3315

Closed
stefanmeschke opened this issue Nov 29, 2016 · 5 comments
Closed

Page reload extremely slow #3315

stefanmeschke opened this issue Nov 29, 2016 · 5 comments
Labels
needs: repro steps We cannot reproduce the issue with the information given

Comments

@stefanmeschke
Copy link

OS

Mac OSX 10.12.1 (16B2555)

Versions

angular-cli: 1.0.0-beta.21
node: 6.5.0
os: darwin x64

Repro steps.

  • Project was created with ng new
  • After putting all dependencies in the AppModule, we decided to create some NgModule to import and export Components/Pipes/... in separate modules
  • After this step the page reload increased extremely. At this point we do not know whats happening inside.

Does anyone has/had the same issue?

Many thanks in advance!

@borislemke
Copy link

@stefanmeschke how slow is slow to you? On my dev machine average reload is around 10 ~ 20 seconds and just under minute with --aot.

@filipesilva
Copy link
Contributor

I wonder if this is the same as #1980 or a separate problem the contributes to it.

@stefanmeschke can I ask you to give me a very precise repro with rebuild times? Something like

  • do ng new
  • do ng serve, change files a couple of times and had this rebuild time (this is important because the first few rebuilds are always slower)
  • changed code in exactly this way
  • repeated step 2, rebuild times are now this.

@filipesilva filipesilva added the needs: repro steps We cannot reproduce the issue with the information given label Dec 30, 2016
@hccampos
Copy link

@stefanmeschke mentions importing and exporting several modules, maybe using index.ts. This is in line with a theory of mine that one of the causes could be index.ts files or modules exporting a bunch of stuff and causing webpack to have to traverse a lot of stuff for each rebuild. I haven't been able to test this theory to confirm or reject it, but will hopefully do that soon.

In any case, since build performance is so abysmal with TS and webpack, it will be really nice to start finding the best ways to code and structure apps in order to keep build times short.

hansl added a commit to hansl/angular-cli that referenced this issue Jan 20, 2017
Keep the TypeScript SourceFile around so we don't regenerate all of them
when we rebuild the Program. The rebuild time is now 40-50% faster for
hello world. This means all the files which haven't changed are not
reparsed.

Mentions: angular#1980, angular#4020, angular#3315
hansl added a commit to hansl/angular-cli that referenced this issue Jan 20, 2017
Keep the TypeScript SourceFile around so we don't regenerate all of them
when we rebuild the Program. The rebuild time is now 40-50% faster for
hello world. This means all the files which haven't changed are not
reparsed.

Mentions: angular#1980, angular#4020, angular#3315
hansl added a commit to hansl/angular-cli that referenced this issue Jan 20, 2017
Keep the TypeScript SourceFile around so we don't regenerate all of them
when we rebuild the Program. The rebuild time is now 40-50% faster for
hello world. This means all the files which haven't changed are not
reparsed.

Mentions: angular#1980, angular#4020, angular#3315
hansl added a commit to hansl/angular-cli that referenced this issue Jan 20, 2017
Keep the TypeScript SourceFile around so we don't regenerate all of them
when we rebuild the Program. The rebuild time is now 40-50% faster for
hello world. This means all the files which haven't changed are not
reparsed.

Mentions: angular#1980, angular#4020, angular#3315
hansl added a commit to hansl/angular-cli that referenced this issue Jan 20, 2017
Keep the TypeScript SourceFile around so we don't regenerate all of them
when we rebuild the Program. The rebuild time is now 40-50% faster for
hello world. This means all the files which haven't changed are not
reparsed.

Mentions: angular#1980, angular#4020, angular#3315
hansl added a commit to hansl/angular-cli that referenced this issue Jan 22, 2017
Keep the TypeScript SourceFile around so we don't regenerate all of them
when we rebuild the Program. The rebuild time is now 40-50% faster for
hello world. This means all the files which haven't changed are not
reparsed.

Mentions: angular#1980, angular#4020, angular#3315
hansl added a commit to hansl/angular-cli that referenced this issue Jan 22, 2017
Keep the TypeScript SourceFile around so we don't regenerate all of them
when we rebuild the Program. The rebuild time is now 40-50% faster for
hello world. This means all the files which haven't changed are not
reparsed.

Mentions: angular#1980, angular#4020, angular#3315
hansl added a commit to hansl/angular-cli that referenced this issue Jan 22, 2017
Keep the TypeScript SourceFile around so we don't regenerate all of them
when we rebuild the Program. The rebuild time is now 40-50% faster for
hello world. This means all the files which haven't changed are not
reparsed.

Mentions: angular#1980, angular#4020, angular#3315
hansl added a commit to hansl/angular-cli that referenced this issue Jan 22, 2017
Keep the TypeScript SourceFile around so we don't regenerate all of them
when we rebuild the Program. The rebuild time is now 40-50% faster for
hello world. This means all the files which haven't changed are not
reparsed.

Mentions: angular#1980, angular#4020, angular#3315
hansl added a commit to hansl/angular-cli that referenced this issue Jan 22, 2017
Keep the TypeScript SourceFile around so we don't regenerate all of them
when we rebuild the Program. The rebuild time is now 40-50% faster for
hello world. This means all the files which haven't changed are not
reparsed.

Mentions: angular#1980, angular#4020, angular#3315
hansl added a commit to hansl/angular-cli that referenced this issue Jan 22, 2017
Keep the TypeScript SourceFile around so we don't regenerate all of them
when we rebuild the Program. The rebuild time is now 40-50% faster for
hello world. This means all the files which haven't changed are not
reparsed.

Mentions: angular#1980, angular#4020, angular#3315
hansl added a commit to hansl/angular-cli that referenced this issue Jan 22, 2017
Keep the TypeScript SourceFile around so we don't regenerate all of them
when we rebuild the Program. The rebuild time is now 40-50% faster for
hello world. This means all the files which haven't changed are not
reparsed.

Mentions: angular#1980, angular#4020, angular#3315
hansl added a commit to hansl/angular-cli that referenced this issue Jan 22, 2017
Keep the TypeScript SourceFile around so we don't regenerate all of them
when we rebuild the Program. The rebuild time is now 40-50% faster for
hello world. This means all the files which haven't changed are not
reparsed.

Mentions: angular#1980, angular#4020, angular#3315
hansl added a commit that referenced this issue Jan 22, 2017
Keep the TypeScript SourceFile around so we don't regenerate all of them
when we rebuild the Program. The rebuild time is now 40-50% faster for
hello world. This means all the files which haven't changed are not
reparsed.

Mentions: #1980, #4020, #3315
@filipesilva
Copy link
Contributor

Closed as inactive.

MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this issue Feb 9, 2017
Keep the TypeScript SourceFile around so we don't regenerate all of them
when we rebuild the Program. The rebuild time is now 40-50% faster for
hello world. This means all the files which haven't changed are not
reparsed.

Mentions: angular#1980, angular#4020, angular#3315
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: repro steps We cannot reproduce the issue with the information given
Projects
None yet
Development

No branches or pull requests

4 participants