Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@ngtools/webpack): keep the decorators in. #3583

Merged
merged 1 commit into from
Dec 15, 2016

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Dec 15, 2016

This is a temporary fix for people using custom decorators. The AOT size will be larger temporarily, but we are working on an actual fix where we rtemove only Angular decorators.

This is a temporary fix for people using custom decorators. The AOT size will be larger temporarily, but we are working on an actual fix where we rtemove only Angular decorators.
@robwormald
Copy link
Contributor

LGTM, assuming green CI 👍

@fxck
Copy link

fxck commented Dec 18, 2016

Can you release this?

@ghost
Copy link

ghost commented Dec 19, 2016

@fxck if you need this urgently, you will need to clone the repository, run "npm link" in that clone, and "npm link angular-cli" in your project.

MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
This is a temporary fix for people using custom decorators. The AOT size will be larger temporarily, but we are working on an actual fix where we rtemove only Angular decorators.
@hansl hansl deleted the remove-remove-decorators branch August 2, 2018 19:56
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants