Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AOT - Decorators are removed - still no solution #6992

Closed
fkolar opened this issue Jul 15, 2017 · 3 comments
Closed

AOT - Decorators are removed - still no solution #6992

fkolar opened this issue Jul 15, 2017 · 3 comments
Labels
needs: repro steps We cannot reproduce the issue with the information given

Comments

@fkolar
Copy link

fkolar commented Jul 15, 2017

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [X] feature request

Versions.

@angular/cli: 1.1.2
node: 6.9.0
os: darwin x64
@angular/animations: 4.1.3
@angular/common: 4.1.3
@angular/compiler: 4.1.3
@angular/core: 4.1.3
@angular/forms: 4.1.3
@angular/http: 4.1.3
@angular/platform-browser: 4.1.3
@angular/platform-browser-dynamic: 4.1.3
@angular/router: 4.1.3
@angular/cli: 1.1.2
@angular/compiler-cli: 4.1.3

Repro steps.

ng build --prod --aot=true and Decorators are removed

Desired functionality.

I know it has been discussed many times here and I see there was made some temporary fix #3583 which was reverted back later on and I dont see any real solution so far.

Is it possible to put in some flags in so its up to the developers to decide wheather they want custom decorators or angular's ?

Mention any other details that might be useful.

When I used AOT with decorators or without them there are still great bundle size optimization. Instead of having 60% of original size I have 55% - which is not that dramatic increase on the size - but still your app can leveradge offline compiled code .

So having some option in place where developers can turn on/off angular decorators or custom would be great feature. Also I read from @hansl the:

Prod builds will only remove decorators that are marked as annotations using tsickle. , but then I havent seen any reference to it.

Even there might be impact on TreeShaking ...

Or somehow include this tsickle like in here:
https://github.com/mlaval/optimize-angular-app

which should even now convert decorators into static class properties and maybe if this already work - this would be the best.

@filipesilva
Copy link
Contributor

Can you provide a runnable repro of the problem please?

@filipesilva filipesilva added the needs: repro steps We cannot reproduce the issue with the information given label Jul 28, 2017
fkolar added a commit to fkolar/decoratorsGone that referenced this issue Jul 28, 2017
@fkolar
Copy link
Author

fkolar commented Jul 28, 2017

I see this is duplicate to this #5670 and all this talks about the same problem where or at least it relates to this.

I tried describe all under this github sample: https://github.com/fkolar/decoratorsGone.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: repro steps We cannot reproduce the issue with the information given
Projects
None yet
Development

No branches or pull requests

3 participants