-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: when running in a headless process in win32 the lack of process.… #4871
Conversation
…stdin throws an error. Fix angular#4870
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
packages/@angular/cli/bin/ng
Outdated
@@ -132,9 +133,20 @@ resolve('@angular/cli', { basedir: process.cwd() }, | |||
cli = cli['default']; | |||
} | |||
|
|||
let standardInput; | |||
if (process.platform === 'win32') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this check is an error; don't you want to set it to process.input
on linux/mac?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct, this is residual from a different approach I had to start with. I'll remove the incorrect check for the platform, thanks.
...due to a bug introduced by previous commit.
When running in a headless process in win32 the lack of process.stdin throws an error. Fixes angular#4870
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…stdin throws an error.
Fix #4870