Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when running in a headless process in win32 the lack of process.… #4871

Merged
merged 2 commits into from
Feb 22, 2017

Conversation

ceottaki
Copy link
Contributor

…stdin throws an error.

Fix #4870

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ceottaki
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@@ -132,9 +133,20 @@ resolve('@angular/cli', { basedir: process.cwd() },
cli = cli['default'];
}

let standardInput;
if (process.platform === 'win32') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this check is an error; don't you want to set it to process.input on linux/mac?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, this is residual from a different approach I had to start with. I'll remove the incorrect check for the platform, thanks.

...due to a bug introduced by previous commit.
@hansl hansl merged commit 4af7a42 into angular:master Feb 22, 2017
@ceottaki ceottaki deleted the fix/win32-process-stdin branch February 23, 2017 10:30
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
When running in a headless process in win32 the lack of process.stdin throws an error.

Fixes angular#4870
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants