Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Flag values that are in a domain should evaluate to the proper case #5344

Closed
johnpapa opened this issue Mar 9, 2017 · 1 comment · Fixed by #5355
Closed

Feature: Flag values that are in a domain should evaluate to the proper case #5344

johnpapa opened this issue Mar 9, 2017 · 1 comment · Fixed by #5355

Comments

@johnpapa
Copy link
Contributor

johnpapa commented Mar 9, 2017

OS?

Mac OSX Sierra 10.12.3

Versions.

@angular/cli: 1.0.0-rc.1
node: 6.9.1
os: darwin x64
@angular/common: 2.4.9
@angular/compiler: 2.4.9
@angular/core: 2.4.9
@angular/forms: 2.4.9
@angular/http: 2.4.9
@angular/platform-browser: 2.4.9
@angular/platform-browser-dynamic: 2.4.9
@angular/router: 3.4.9
@angular/cli: 1.0.0-rc.1
@angular/compiler-cli: 2.4.9

Repro steps.

ng g c foo -cd onpush should generate one with OnPush using proper casing

The log given by the failure.

Currently it generates this ... changeDetection: ChangeDetectionStrategy.onpush

but i propose it should generate this

changeDetection: ChangeDetectionStrategy.OnPush

Mention any other details that might be useful.

The key here is that the flag should be examined and not taken verbatim. But instead, evalauted and replaced with the appropriate value.

This should apply to anyplace domains are used as values.

  1. changeDetection --> ng g c foo -cd onpush
  2. viewEncapsulation --> ng g c foo -ve emulated
@Brocco Brocco self-assigned this Mar 9, 2017
Brocco added a commit to Brocco/angular-cli that referenced this issue Mar 9, 2017
Brocco added a commit to Brocco/angular-cli that referenced this issue Mar 9, 2017
@johnpapa johnpapa changed the title Flag values that are in a domain should evaluate to the proper case Feature: Flag values that are in a domain should evaluate to the proper case Mar 11, 2017
ocombe added a commit to ocombe/angular-cli that referenced this issue Mar 13, 2017
fix(@angular/cli): make flag values case insensitive (angular#5355)

Fixes angular#5344
docs(@angular/cli): fixing broken ng doc link in wiki

ng docs --> ng doc
style: blueprint consistency (angular#5392)


docs(@angular/cli): services are provided, not declared

docs(@angular/cli): services are provided, not declared
Merge branch 'master' into docs-i18n-story
docs(@angular/cli): add i18n commands and story
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this issue Apr 12, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants