Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ng test -sm false seems to generate sourcemaps #5666

Closed
johnpapa opened this issue Mar 26, 2017 · 4 comments
Closed

ng test -sm false seems to generate sourcemaps #5666

johnpapa opened this issue Mar 26, 2017 · 4 comments
Labels
freq2: medium P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful severity2: inconvenient type: bug/fix

Comments

@johnpapa
Copy link
Contributor

OS

Mac OSX Sierra 10.12.3

Versions

@angular/cli: 1.0.0
node: 6.9.1
os: darwin x64
@angular/common: 4.0.0
@angular/compiler: 4.0.0
@angular/core: 4.0.0
@angular/forms: 4.0.0
@angular/http: 4.0.0
@angular/material: 2.0.0-beta.2
@angular/platform-browser: 4.0.0
@angular/platform-browser-dynamic: 4.0.0
@angular/router: 4.0.0
@angular/cli: 1.0.0
@angular/compiler-cli: 4.0.0

Repro steps.

ng test -sm false

This should run tests without the source maps. However, we can still debug into source maps.

// As noted by @wardbell, also

2017-03-26_11-52-26
@filipesilva filipesilva added command: test freq2: medium P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful severity2: inconvenient type: bug/fix labels Mar 26, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Mar 26, 2017
@filipesilva
fix(@angular/cli): fix sourcemap toggle in ng test
6f800c6 
Followup to angular#5422
Fix angular#5666
@filipesilva
Copy link
Contributor

This is not intended, it is a bug. Sourcemaps are not being correctly turned off.

@johnpapa this explains why disabling sourcemaps didn't improve test rebuilds anymore.

@filipesilva filipesilva mentioned this issue Mar 26, 2017
Closed
@johnpapa
Copy link
Contributor Author

Good to know I'm not nuts :)

@hccampos
Copy link

@filipesilva any idea when a minor bump will be released with this? Seems like all the development is going on in 1.1.x while 1.0.0 is left with several bugs that have been fixed a while back.

dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this issue Apr 23, 2018
@filipesilva @dond2clouds
fix(@angular/cli): fix sourcemap toggle in ng test
ddb7270 
Followup to angular#5422
Fix angular#5666
Close angular#5668
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
freq2: medium P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful severity2: inconvenient type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(@angular/cli): fix sourcemap toggle in ng test filipesilva/angular-cli
3 participants
@johnpapa @hccampos @filipesilva