scripts path in index.html does not follow deployUrl defined in .angular-cli.json in 1.4.0 #7628

h657070128 · 2017-09-08T08:05:28Z

Bug Report or Feature Request (mark with an `x`)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.

@angular/cli: 1.4.0
node: 8.0.0
os: darwin x64
@angular/animations: 4.3.6
@angular/common: 4.3.6
@angular/compiler: 4.3.6
@angular/core: 4.3.6
@angular/forms: 4.3.6
@angular/http: 4.3.6
@angular/platform-browser: 4.3.6
@angular/platform-browser-dynamic: 4.3.6
@angular/router: 4.3.6
@angular/cli: 1.3.2
@angular/compiler-cli: 4.3.6
@angular/language-service: 4.3.6

Repro steps.

.angular-cli.json: (Note the deployUrl)

"apps": [
    {
      "root": "src",
      "outDir": "target/my-app",
      "deployUrl": "my-app",
      "assets": [],
      "index": "index.html",
      "main": "main.ts",
      "polyfills": "polyfills.ts",
      "tsconfig": "tsconfig.app.json",
      "styles": [
        "styles.css"
      ],
      "scripts": [
        "../node_modules/some-libs/file.js",
      ]
    }
  ]

After I run ng build --prod, the index.html in target/my-app:

...
<body>
    <my-app></my-app>
    <script type="text/javascript" src="my-app/inline.6cca322f7e258972d83b.bundle.js"></script>
    <script type="text/javascript" src="my-app/polyfills.1f88e2c5c51b2654c108.bundle.js"></script>
    <script type="text/javascript" src="scripts.4b3dfabee60e0d1b2077.bundle.js"></script>
    <script type="text/javascript" src="my-app/vendor.7e4452b3f0246d32e944.bundle.js"></script>
    <script type="text/javascript" src="my-app/main.4f222f38a3c2a53f4f40.bundle.js"></script>
</body>
...

Note the scripts path is not under my-app, but the the scripts file is under my-app directory. As a result, scripts cannot be fount in browser.

1.3.2 does not have this problem.
Thanks!

The text was updated successfully, but these errors were encountered:

mgpeter · 2017-09-08T11:31:36Z

Same issue here.

Versions:

@angular/cli: 1.4.0
node: 6.11.2
os: win32 x64
@angular/animations: 4.3.6
@angular/common: 4.3.6
@angular/compiler: 4.3.6
@angular/core: 4.3.5
@angular/forms: 4.3.6
@angular/http: 4.3.6
@angular/platform-browser: 4.3.6
@angular/platform-browser-dynamic: 4.3.6
@angular/router: 4.3.6
@angular/cli: 1.4.0
@angular/compiler-cli: 4.3.6
@angular/language-service: 4.3.6
@angular/platform-server: 4.3.6
typescript: 2.4.2

Repro:
.angular-cli.json:

"apps": [

        {
            "root": "src",
            "outDir": "dist",
            "assets": [
                "assets",
                "favicon.ico"


            ],
            "index": "index.html",
            "main": "main.ts",
            "polyfills": "polyfills.ts",
            "test": "test.ts",
            "tsconfig": "tsconfig.app.json",
            "testTsconfig": "tsconfig.spec.json",
            "prefix": "app",
            "styles": [
                "assets/styles/jquery.bxslider.css",
                "assets/styles/main.scss"
            ],
            "scripts": [
                "assets/scripts_include/jquery-1.11.3.min.js",
                "assets/scripts_include/jquery-ui.min.js",
                "assets/scripts_include/jquery.ui.touch-punch.min.js",
                "assets/scripts_include/jquery.bxslider.min.js"
            ],
            "environmentSource": "environments/environment.ts",
            "environments": {
                "dev": "environments/environment.ts",
                "prod": "environments/environment.prod.ts",
                "qa": "environments/environment.qa.ts",
                "uat": "environments/environment.uat.ts"
            }
        }
]

Running ng build --dev --environment=dev --deploy-url=/dist/ -sm results in index.html with botched scripts file reference:

    <script type="text/javascript" src="/dist/inline.bundle.js"></script>
    <script type="text/javascript" src="/dist/polyfills.bundle.js"></script>
    <script type="text/javascript" src="scripts.bundle.js"></script>
    <script type="text/javascript" src="/dist/styles.bundle.js"></script>
    <script type="text/javascript" src="/dist/vendor.bundle.js"></script>
    <script type="text/javascript" src="/dist/main.bundle.js"></script>

Workaround for now is to fix the path manually, but it is a small issue during development.

Additional info:
I haven't had a chance to investigate properly, but I'm somewhat sure the issue was introduced within e8f27f0 , see the new logic for globalScriptsByEntry reduce in packages/@angular/cli/models/webpack-configs/common.ts and the new logic in packages/@angular/cli/plugins/insert-concat-assets-webpack-plugin.ts

rvandehei · 2017-09-08T13:16:27Z

same here. How soon do they normally fix these sort of bugs? This was an untimely release for us.

hansl · 2017-09-08T18:30:36Z

We should fix this one ASAP. I'm investigating and will try to do an emergency release today.

Fixes angular#7628

Fixes #7628

hansl · 2017-09-08T22:54:30Z

This has been released in 1.4.1. Try it out and if there's a problem, open another issue please.

AlexOliinyk1 · 2017-09-13T07:15:53Z

@hansl updated to 1.4.1
but my problem still looks like this wrong path

Fixes angular#7628

angular-automatic-lock-bot · 2019-09-08T05:41:15Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

hansl added a commit to hansl/angular-cli that referenced this issue Sep 8, 2017

fix(@angular/cli): take publicPath into account when building entry map

31276bc

Fixes angular#7628

hansl mentioned this issue Sep 8, 2017

fix(@angular/cli): take publicPath into account when building entry map #7634

Merged

hansl added a commit to hansl/angular-cli that referenced this issue Sep 8, 2017

fix(@angular/cli): take publicPath into account when building entry map

de43901

Fixes angular#7628

hansl closed this as completed in #7634 Sep 8, 2017

hansl added a commit that referenced this issue Sep 8, 2017

fix(@angular/cli): take publicPath into account when building entry map

e0a70a3

Fixes #7628

hansl added a commit that referenced this issue Sep 8, 2017

fix(@angular/cli): take publicPath into account when building entry map

e6f3841

Fixes #7628

deanfischer mentioned this issue Sep 11, 2017

Using an absolute deployUrl breaks the 'scripts' bundle url in index.html #7650

Closed

dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this issue Apr 23, 2018

fix(@angular/cli): take publicPath into account when building entry map

861cc1c

Fixes angular#7628

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

scripts path in index.html does not follow deployUrl defined in .angular-cli.json in 1.4.0 #7628

scripts path in index.html does not follow deployUrl defined in .angular-cli.json in 1.4.0 #7628

h657070128 commented Sep 8, 2017

mgpeter commented Sep 8, 2017 •

edited

Loading

rvandehei commented Sep 8, 2017

hansl commented Sep 8, 2017

hansl commented Sep 8, 2017

AlexOliinyk1 commented Sep 13, 2017

angular-automatic-lock-bot bot commented Sep 8, 2019

scripts path in index.html does not follow deployUrl defined in .angular-cli.json in 1.4.0 #7628

scripts path in index.html does not follow deployUrl defined in .angular-cli.json in 1.4.0 #7628

Comments

h657070128 commented Sep 8, 2017

Bug Report or Feature Request (mark with an x)

Versions.

Repro steps.

mgpeter commented Sep 8, 2017 • edited Loading

rvandehei commented Sep 8, 2017

hansl commented Sep 8, 2017

hansl commented Sep 8, 2017

AlexOliinyk1 commented Sep 13, 2017

angular-automatic-lock-bot bot commented Sep 8, 2019

Bug Report or Feature Request (mark with an `x`)

mgpeter commented Sep 8, 2017 •

edited

Loading