Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: edit ng serve option doc #13210

Merged
merged 3 commits into from
Dec 26, 2018
Merged

docs: edit ng serve option doc #13210

merged 3 commits into from
Dec 26, 2018

Conversation

jbogarthyde
Copy link
Contributor

Edit doc for ng serve to resolve Issue
#8986

@jbogarthyde jbogarthyde added effort1: easy (hours) P5 The team acknowledges the request but does not plan to address it, it remains open for discussion area: docs Related to the documentation freq1: low Only reported by a handful of users who observe it rarely severity1: confusing area: @angular/cli action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Dec 17, 2018
filipesilva
filipesilva suggested changes Dec 18, 2018
View reviewed changes
packages/angular/cli/lib/config/schema.json Outdated
"default": true
},
"publicHost": {
"type": "string",
"description": "Specify the URL that the browser client will use."
"description": "The URL that the browser client will use for live reload."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

publicHost is not just about live-reload. @clydin can you offer a better description please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for live reload -> to connect to the development server

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was that the user didn't relate publicHost to live-reload. How about this:
"The URL that the browser client will use to connect to the development server for live-reload."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clydin Please check new text

@ngbot
Copy link

ngbot bot commented Dec 20, 2018

Artifact Baseline Current Change
❕ cli/new-production/test-project/main.js 174.25KB 174.25KB +3 bytes

1 similar comment
@ngbot
Copy link

ngbot bot commented Dec 20, 2018

Artifact Baseline Current Change
❕ cli/new-production/test-project/main.js 174.25KB 174.25KB +3 bytes

@clydin clydin assigned filipesilva and unassigned clydin Dec 21, 2018
@jbogarthyde jbogarthyde removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 21, 2018
@jbogarthyde
Copy link
Contributor Author

There's no Mark for Merge label - is there something else I have to do to get this merged? @filipesilva

@filipesilva
Copy link
Contributor

@jbogarthyde it's just waiting for the caretaker to merge it now, I think. There's nothing else that needs to be done.

@hansl hansl merged commit 4729397 into angular:master Dec 26, 2018
@jbogarthyde jbogarthyde deleted the jb-ng-serve-doc branch April 1, 2019 20:57
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@filipesilva filipesilva filipesilva approved these changes

@clydin clydin clydin approved these changes

Assignees

@filipesilva filipesilva

Labels
area: @angular/cli area: docs Related to the documentation effort1: easy (hours) freq1: low Only reported by a handful of users who observe it rarely P5 The team acknowledges the request but does not plan to address it, it remains open for discussion severity1: confusing target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jbogarthyde @filipesilva @clydin @hansl @googlebot