Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add loader for gif #1888

Closed
wants to merge 1 commit into from
Closed

fix: add loader for gif #1888

wants to merge 1 commit into from

Conversation

FallenRiteMonk
Copy link
Contributor

add loader to support loading of gif images

Closes #1878

@billdwhite
Copy link

+1 on getting this merged in!

@eabehrens
Copy link

+1 for this!

@EricBou
Copy link

EricBou commented Sep 7, 2016

+1 for this

@dballance
Copy link

Lack of .gif support is a blocker for me -- looks like a quick win to include this.

@RicardoVaranda
Copy link
Contributor

What exactly does this enable you to do?

@TheLarkInn
Copy link
Member

@FallenRiteMonk 2 things:

  1. What is the purpose for choosing this over url-loader or file-loader?
  2. To merge, we need tests verifying this functionality works.

{ test: /\.gif$/i,
loaders: [
'file?hash=sha512&digest=hex&name=[hash].[ext]',
'image-webpack?bypassOnDebug&optimizationLevel=7&interlaced=false'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all these query options for the image min library?

@FallenRiteMonk
Copy link
Contributor Author

  1. I don't know. I'm totally new to webpack so I just googled and found this example that worked for me, but I now figured out that url-loader also works and fixed it, hope this is better.
  2. Could you please give me a quick heads up on what kind of test would be needed and where it should go? (where are other tests for webpack loader configurations)

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot
Copy link

CLAs look good, thanks!

# The first commit's message is:
fix: add loader for gif

add loader to support loading of gif images

Closes #1878

# The 2nd commit message will be skipped:

#	fix(lint): Updated the main.ts's blueprint to fix the ng lint failure (#1903) (#1904)
#

# The 3rd commit message will be skipped:

#	Fix for issue 1876: noImplicitAny means make them explicite (#1892)
#
@FallenRiteMonk
Copy link
Contributor Author

messed this up with rebase! created a new PR #2066

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Primeng/Primeui webpack Module parse failed Unexpected character
8 participants