Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(@angular-devkit/build-angular): use esbuild as a CSS optimizer for global styles #21535

Merged
merged 1 commit into from
Aug 10, 2021
Merged

perf(@angular-devkit/build-angular): use esbuild as a CSS optimizer for global styles #21535

merged 1 commit into from
Aug 10, 2021

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Aug 9, 2021

Esbuild now support CSS sourcemaps which now makes it possible to be used to optimize global CSS.

Extension of #21323

@google-cla google-cla bot added the cla: yes label Aug 9, 2021
@alan-agius4 alan-agius4 marked this pull request as ready for review August 9, 2021 14:28
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Aug 9, 2021
@alan-agius4 alan-agius4 requested a review from clydin August 9, 2021 14:28
@alan-agius4 alan-agius4 requested a review from clydin August 10, 2021 06:41
…or global styles

Esbuild now support CSS sourcemaps which now makes it possible to be used to optimize global CSS.

With this change we also reduce the amount of dependencies by removing `css-minimizer-webpack-plugin` which brings in a number of transitive depedencies which we no longer use.
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Aug 10, 2021
@alan-agius4 alan-agius4 merged commit cb7d156 into angular:master Aug 10, 2021
@alan-agius4 alan-agius4 deleted the esbuild-global-css branch August 10, 2021 17:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants