Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: swap out raw-loader for html-loader for html files #2298

Closed

Conversation

TheLarkInn
Copy link
Member

@TheLarkInn TheLarkInn commented Sep 22, 2016

* angular html components as well as index.html now have the benefits of html-loader

@hansl
Copy link
Contributor

hansl commented Sep 22, 2016

LGTM. I'll wait for tests to pass.

@TheLarkInn
Copy link
Member Author

Looks like tests failed on basehref, I'll give this another whirl

@alexsorokoletov
Copy link

Almost there, would be great to have this fixed in the coming update!
Thank you, @TheLarkInn

@filipesilva
Copy link
Contributor

TBH if you wanna replace our custom base href plugin by base functionality of HTMLPlugin, I can't say I mind. Might be the sort of stuff that would happen in a different commit/pr.

filipesilva pushed a commit that referenced this pull request Sep 26, 2016
@ghost
Copy link

ghost commented Sep 28, 2016

Will this PR be merged soon? :)

@hansl
Copy link
Contributor

hansl commented Sep 29, 2016

@TheLarkInn Have you tried running ng build --base-href /url in a new project and look if the base is there? To me it seems like this breakage is legit.

@TheLarkInn
Copy link
Member Author

@hansl I noticed that in your PR you had html-loader (the AOT one), so I hadn't revisited it.

@TheLarkInn
Copy link
Member Author

I'll take a look at this next and see what errors are being caused.

@filipesilva
Copy link
Contributor

Closed since we removed this in #2537

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack skips images referenced in html templates (img src)
5 participants