fix(@angular-devkit/build-angular): process stylesheet resources from url tokens with esbuild browser builder #23706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
esbuild/css-resources
branch
from
97e07c9
to
e84a40b
Compare
alan-agius4
reviewed
Aug 8, 2022
packages/angular_devkit/build_angular/src/builders/browser-esbuild/css-resource-plugin.ts
Show resolved
Hide resolved
… url tokens with esbuild browser builder Stylesheet url tokens (`url(....)`) will now be processed when using the esbuild-based experimental browser application builder. The paths will be resolved via the bundler's resolution system and then loaded via the bundler's `file` loader. The functionality is implemented using an esbuild plugin to allow for all file types to be supported without the need to manually specify each current and future file extension within the build configuration. The `externalDependencies` option also applies to the referenced resources. This allows for resource paths specified with the option to remain unprocessed within the application output. This is useful if the relative path for the resource does not exist on disk but will be available when the application is deployed.
clydin
force-pushed
the
esbuild/css-resources
branch
from
e84a40b
to
e1a8b0a
Compare
alan-agius4
approved these changes
Aug 9, 2022
alan-agius4
added
target: patch
15 tasks
clydin
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stylesheet url tokens (
url(....)) will now be processed when using the esbuild-based experimental browserapplication builder. The paths will be resolved via the bundler's resolution system and then loaded
via the bundler's
fileloader. The functionality is implemented using an esbuild plugin to allow for allfile types to be supported without the need to manually specify each current and future file extension within
the build configuration.
The
externalDependenciesoption also applies to the referenced resources. This allows for resource pathsspecified with the option to remain unprocessed within the application output. This is useful if the relative
path for the resource does not exist on disk but will be available when the application is deployed.