Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(commands): throw when init command is called with mobile flag #2753

Merged
merged 1 commit into from
Oct 17, 2016

Conversation

hollannikas
Copy link
Contributor

@hollannikas hollannikas commented Oct 17, 2016

Show error message when user uses the mobile flag in conjunction with the init command.

Closes #2679

A bit uncertain if the acceptance test is the correct place to test this, as I assume re-enabling the mobile flag is in progress.

Show error message when user uses the mobile flag in conjunction with the init command.

Closes angular#2679
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the correct place to me for now, we'll move it when re-enabling the mobile flag. Thanks!

@filipesilva filipesilva merged commit 9b1c3e0 into angular:master Oct 17, 2016
@hollannikas hollannikas deleted the init-mobile-flag branch October 18, 2016 03:01
Brocco pushed a commit that referenced this pull request Oct 19, 2016
Show error message when user uses the mobile flag in conjunction with the init command.

Closes #2679
kieronqtran pushed a commit to kieronqtran/angular-cli that referenced this pull request Oct 21, 2016
Show error message when user uses the mobile flag in conjunction with the init command.

Closes angular#2679
texel pushed a commit to splice/angular-cli that referenced this pull request Nov 3, 2016
Show error message when user uses the mobile flag in conjunction with the init command.

Closes angular#2679
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng init --mobile flag breaks builds
3 participants