Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/build): normalize paths during module resolution in Vite #27946

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

alan-agius4
Copy link
Collaborator

Before this update, the importer path was not normalized, causing mismatches during SSR on Windows.

Before this update, the importer path was not normalized, causing mismatches during SSR on Windows.
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Jun 27, 2024
@alan-agius4 alan-agius4 requested a review from clydin June 27, 2024 06:58
@alan-agius4 alan-agius4 added target: rc This PR is targeted for the next release-candidate and removed target: minor This PR is targeted for the next minor release labels Jun 27, 2024
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 27, 2024
@alan-agius4 alan-agius4 merged commit 30473f9 into angular:main Jun 27, 2024
34 checks passed
@alan-agius4 alan-agius4 deleted the vite-windows-normalize branch June 27, 2024 11:43
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 18.1.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants