Remove Protractor Builder #28632
Merged
Remove Protractor Builder #28632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
detected: breaking change
dgp1130
force-pushed
the
rm-protractor
branch
from
33c80de
to
364298d
Compare
alan-agius4
reviewed
Oct 15, 2024
…d schematics BREAKING CHANGE: Protractor is no longer supported. Protractor was marked end-of-life in August 2023 (see https://protractortest.org/). Projects still relying on Protractor should consider migrating to another E2E testing framework, several support solid migration paths from Protractor. * https://angular.dev/tools/cli/end-to-end * https://blog.angular.dev/the-state-of-end-to-end-testing-with-angular-d175f751cb9c
…rivate-protractor`
dgp1130
force-pushed
the
rm-protractor
branch
from
364298d
to
2341b36
Compare
|
I patched this change into the FW and Components repos. angular/angular#58254 should be enough to update FW. Components actually doesn't seem to be affected at all. All their Protractor usage comes through Bazel, they don't invoke it through Angular CLI. Once this lands, we should do another |
alan-agius4
added
the
action: review
alan-agius4
reviewed
Oct 21, 2024
| @@ -111,7 +111,7 @@ | |||
| "prefix": "", | |||
There was a problem hiding this comment.
Any changes with core can be reverted as this are just test file.
alan-agius4
approved these changes
Oct 21, 2024
dgp1130
added
action: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the Protractor builder and its
e2egenerator schematic to mark them private and remove them from Angular's public API. This will give us an opportunity to clean up internal usages and then remove the builder altogether in a future release. Since this rename makes Protractor non-public API, it may be completely deleted in a future patch release.Protractor was marked end-of-life in August 2023. Projects still relying on Protractor should consider migrating to another E2E testing framework, several support solid migration paths from Protractor.
Additional resources: