fix(@angular/build): relax constraints on external stylesheet component id #28658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt id The number of digits in the component identifier that is generated at runtime can vary. The check for a valid identifier now accounts for this case.
clydin
added
action: review
alan-agius4
approved these changes
Oct 17, 2024
alan-agius4
added
action: merge
|
I guess this will come in the next release in a weeks time.. thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of digits in the component identifier that is generated at runtime can vary. The check for a valid identifier now accounts for this case.
Closes: #28656