refactor: remove workarounds for Safari 14 and 15 #28682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both of these versions are no longer supported by Angular and thus these workers are no longer required.
alan-agius4
force-pushed
the
safari-15-workarounds
branch
from
a2591a9
to
f436c7c
Compare
alan-agius4
changed the title
alan-agius4
added
action: review
alan-agius4
requested review from
clydin and
dgp1130
and removed request for
clydin
dgp1130
approved these changes
Oct 22, 2024
alan-agius4
added
action: merge
|
I was leaning towards not doing this but waiting a bit longer because:
|
|
I’m not very strongly about this, but we haven’t officially supported Safari 15 for quite a while now, and currently, we support the two most recent major versions of Safari, which are 17 and 18. I agree that keeping this code is low maintenance, though. //cc @dgp1130 thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of these versions are no longer supported by Angular and thus these workers are no longer required.