Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add "version" prop to schematics collection schema #28716

Closed
wants to merge 1 commit into from

Conversation

davidlj95
Copy link
Contributor

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

collection-schema.json file is a schema to define a schematics collection JSON file.

However, it's missing the schematics' version property used for ng update migration schematics.

Issue Number: N/A

What is the new behavior?

Add the missing version property with a description. Optional as for rest of schematics it's not used AFAIK.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! However, this isn’t quite right. Schematics are at a higher level and aren’t aware of ng update logic.

@davidlj95 davidlj95 deleted the collection-schema-version branch October 25, 2024 11:10
@davidlj95
Copy link
Contributor Author

Thank you for your contribution! However, this isn’t quite right. Schematics are at a higher level and aren’t aware of ng update logic.

Makes sense! Thx 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants