Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(@schematics/angular): add required type to CanDeactivate guard #29004

Merged
merged 1 commit into from
Dec 2, 2024
Merged

refactor(@schematics/angular): add required type to CanDeactivate guard #29004

merged 1 commit into from
Dec 2, 2024

Conversation

guiseek
Copy link
Contributor

@guiseek guiseek commented Dec 1, 2024

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release merge: squash commits When the PR is merged, a squash and merge should be performed merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Dec 2, 2024
alan-agius4
alan-agius4 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Dec 2, 2024
@alan-agius4 alan-agius4 merged commit af87780 into angular:main Dec 2, 2024
35 checks passed
@alan-agius4
Copy link
Collaborator

The changes were merged into the following branches: main, 19.0.x

alan-agius4 pushed a commit that referenced this pull request Dec 2, 2024
@guiseek @alan-agius4
fix(@schematics/angular): add required type to CanDeactivate guard (#…
28a51cc 
…29004)

Add missing required generic type in spec file template.

(cherry picked from commit af87780)
@guiseek
Copy link
Contributor Author

guiseek commented Dec 3, 2024

LGTM, thanks for your contribution

you're welcome, man

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: @schematics/angular merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed merge: squash commits When the PR is merged, a squash and merge should be performed target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guiseek @alan-agius4