Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoprefixer): Added autoprefixer to prod #3164

Closed
wants to merge 1 commit into from

Conversation

grizzm0
Copy link
Contributor

@grizzm0 grizzm0 commented Nov 16, 2016

There does not seem to be any webpack plugin available to merge webpack.LoaderOptionsPlugin().

Instead we could define all postcss-plugins we want to use per environment as there might be some plugins in the future which we only want in dev.

Does anyone know if the test: /\.(css|scss|sass|less|styl)$/ is actually needed? My postcss-discard-comments did not have it while autoprefixer did.

Fixes #3156

@hansl
Copy link
Contributor

hansl commented Nov 16, 2016

@TheLarkInn @filipesilva Can one of you review this PR (and answer the questions above)? I'm personally fine with it.

Copy link
Member

@TheLarkInn TheLarkInn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autoprefixer not working for serving prod builds
5 participants