Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): for stylus create app.component.styl, not .stylus #4540

Merged

Conversation

catull
Copy link
Contributor

@catull catull commented Feb 8, 2017

This PR fixes #2191.

@catull catull changed the title Stylus files end in .stylus, thus all file extension checks need to check for '.stylys$', not '.styl$'. Stylus files end in .stylus, thus all file extension checks need to check for '.stylus$', not '.styl$'. Feb 8, 2017
@grizzm0
Copy link
Contributor

grizzm0 commented Feb 8, 2017

.styl is the official extension for stylus.

@catull catull force-pushed the fix-stylus-files-extensions-appropriately branch from 26d64b7 to 7825200 Compare February 8, 2017 22:48
@catull catull changed the title Stylus files end in .stylus, thus all file extension checks need to check for '.stylus$', not '.styl$'. fix(new/Stylus): create app.component.styl, not .stylus Feb 8, 2017
@hansl
Copy link
Contributor

hansl commented Feb 9, 2017

Could you rebase this on top of master? LGTM, but the tests should pass.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Feb 9, 2017
@catull catull force-pushed the fix-stylus-files-extensions-appropriately branch from cc5212d to 8faf219 Compare February 9, 2017 01:21
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Feb 9, 2017
@catull catull changed the title fix(new/Stylus): create app.component.styl, not .stylus fix(@angular/cli): for stylus create app.component.styl, not .stylus Feb 9, 2017
@hansl hansl merged commit 0f7a35f into angular:master Feb 9, 2017
@catull catull deleted the fix-stylus-files-extensions-appropriately branch February 9, 2017 19:09
hansl pushed a commit to hansl/angular-cli that referenced this pull request Feb 9, 2017
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fresh --style=stylus install does not work / runtime error
5 participants