refactor(@angular/cli): use shared configs for ng test #4851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
force-pushed
the
use-test-ts-config
branch
from
9eb7cf0
to
34acb94
Compare
hansl
suggested changes
Feb 21, 2017
There was a problem hiding this comment.
LGTM with one nit: this is a feature, not a refactor. The behavior changed and we need a line in the changelog. Also, could you split this in 2 commits; a feat(@angular/cli): use same webpack config for karma, and a feat(@ngtools/webpack): allow to pass in overrides for compilerOptions. Makes sense?
filipesilva
force-pushed
the
use-test-ts-config
branch
2 times, most recently
from
2fa1737
to
dfc2a63
Compare
hansl
approved these changes
Feb 21, 2017
filipesilva
force-pushed
the
use-test-ts-config
branch
from
dfc2a63
to
e5c63cb
Compare
filipesilva
added a commit
that referenced
this pull request
Feb 22, 2017
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Karma plugin will find the CLI config without needing to be told where it is as well.
Fix #3605
Fix #4850
Fix #4876