feat(@angular/cli): name lazy chunks #6881

filipesilva · 2017-07-04T18:09:49Z

Before:

$ ng build --no-progress
Hash: ff03df269349b817eef4
Time: 11202ms
chunk    {0} 0.chunk.js, 0.chunk.js.map 1.61 kB {1} {3} [rendered]
chunk    {1} 1.chunk.js, 1.chunk.js.map 1.46 kB {0} {3} [rendered]
chunk    {2} polyfills.bundle.js, polyfills.bundle.js.map (polyfills) 160 kB {6} [initial] [rendered]
chunk    {3} main.bundle.js, main.bundle.js.map (main) 6.38 kB {5} [initial] [rendered]
chunk    {4} styles.bundle.js, styles.bundle.js.map (styles) 10.5 kB {6} [initial] [rendered]
chunk    {5} vendor.bundle.js, vendor.bundle.js.map (vendor) 2.16 MB [initial] [rendered]
chunk    {6} inline.bundle.js, inline.bundle.js.map (inline) 0 bytes [entry] [rendered]

After:

$ ng build --no-progress
Hash: 2bc12a89f40f3b4818b5
Time: 9613ms
chunk {feature.module} feature.module.chunk.js, feature.module.chunk.js.map 1.46 kB {lazy.module} {main} [rendered]
chunk {inline} inline.bundle.js, inline.bundle.js.map (inline) 0 bytes [entry] [rendered]
chunk {lazy.module} lazy.module.chunk.js, lazy.module.chunk.js.map 1.61 kB {feature.module} {main} [rendered]
chunk {main} main.bundle.js, main.bundle.js.map (main) 6.38 kB {vendor} [initial] [rendered]
chunk {polyfills} polyfills.bundle.js, polyfills.bundle.js.map (polyfills) 160 kB {inline} [initial] [rendered]
chunk {styles} styles.bundle.js, styles.bundle.js.map (styles) 10.5 kB {inline} [initial] [rendered]
chunk {vendor} vendor.bundle.js, vendor.bundle.js.map (vendor) 2.16 MB [initial] [rendered]

Fix #6700

hansl · 2017-07-04T18:12:33Z

packages/@angular/cli/plugins/named-lazy-chunks-webpack-plugin.ts

+      return name();
+    };
+
+    return new (webpack as any).NamedChunksPlugin(function (chunk: any) {


I don't think it's best practice for a constructor to return another class. Could you instead extends NamedChunksPlugin?

Before: ``` $ ng build --no-progress Hash: ff03df269349b817eef4 Time: 11202ms chunk {0} 0.chunk.js, 0.chunk.js.map 1.61 kB {1} {3} [rendered] chunk {1} 1.chunk.js, 1.chunk.js.map 1.46 kB {0} {3} [rendered] chunk {2} polyfills.bundle.js, polyfills.bundle.js.map (polyfills) 160 kB {6} [initial] [rendered] chunk {3} main.bundle.js, main.bundle.js.map (main) 6.38 kB {5} [initial] [rendered] chunk {4} styles.bundle.js, styles.bundle.js.map (styles) 10.5 kB {6} [initial] [rendered] chunk {5} vendor.bundle.js, vendor.bundle.js.map (vendor) 2.16 MB [initial] [rendered] chunk {6} inline.bundle.js, inline.bundle.js.map (inline) 0 bytes [entry] [rendered] ``` After: ``` $ ng build --no-progress Hash: 2bc12a89f40f3b4818b5 Time: 9613ms chunk {feature.module} feature.module.chunk.js, feature.module.chunk.js.map 1.46 kB {lazy.module} {main} [rendered] chunk {inline} inline.bundle.js, inline.bundle.js.map (inline) 0 bytes [entry] [rendered] chunk {lazy.module} lazy.module.chunk.js, lazy.module.chunk.js.map 1.61 kB {feature.module} {main} [rendered] chunk {main} main.bundle.js, main.bundle.js.map (main) 6.38 kB {vendor} [initial] [rendered] chunk {polyfills} polyfills.bundle.js, polyfills.bundle.js.map (polyfills) 160 kB {inline} [initial] [rendered] chunk {styles} styles.bundle.js, styles.bundle.js.map (styles) 10.5 kB {inline} [initial] [rendered] chunk {vendor} vendor.bundle.js, vendor.bundle.js.map (vendor) 2.16 MB [initial] [rendered] ``` Fix angular#6700

hansl

LGTM

Followup to angular#6881 Also name chunks created via `import()` or `System.import()`.

Followup to angular#6881 Also name chunks created via `import()` or `System.import()`, and strip `.ngfactory` from the chunk name.

Followup to #6881 Also name chunks created via `import()` or `System.import()`, and strip `.ngfactory` from the chunk name.

Followup to angular#6881 Allow controlling chunk naming via the `--named-chunks` flag, which can be set on `.angular-cli.json` as well. Defaults to true in development, false in production.

Followup to #6881 Allow controlling chunk naming via the `--named-chunks` flag, which can be set on `.angular-cli.json` as well. Defaults to true in development, false in production.

Followup to angular#6881 Also name chunks created via `import()` or `System.import()`, and strip `.ngfactory` from the chunk name.

Followup to angular#6881 Allow controlling chunk naming via the `--named-chunks` flag, which can be set on `.angular-cli.json` as well. Defaults to true in development, false in production.

angular-automatic-lock-bot · 2019-09-12T02:41:19Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Jul 4, 2017

hansl reviewed Jul 4, 2017

View reviewed changes

filipesilva force-pushed the named-chunks branch 4 times, most recently from 56deef3 to d8dd3eb Compare July 4, 2017 20:26

filipesilva assigned Brocco Jul 4, 2017

filipesilva requested review from hansl and Brocco July 4, 2017 21:48

filipesilva force-pushed the named-chunks branch from d8dd3eb to f888245 Compare July 5, 2017 18:51

hansl approved these changes Jul 5, 2017

View reviewed changes

hansl merged commit 5a0e80f into angular:master Jul 5, 2017

filipesilva deleted the named-chunks branch July 5, 2017 21:52

filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Jul 10, 2017

feat(@angular/cli): allow chunk names for imports

da63caa

Followup to angular#6881 Also name chunks created via `import()` or `System.import()`.

filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Jul 10, 2017

feat(@angular/cli): allow chunk names for imports

2e11974

Followup to angular#6881 Also name chunks created via `import()` or `System.import()`, and strip `.ngfactory` from the chunk name.

filipesilva mentioned this pull request Jul 10, 2017

feat(@angular/cli): allow chunk names for imports #6935

Merged

filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Jul 10, 2017

feat(@angular/cli): allow chunk names for imports

fc1765c

Followup to angular#6881 Also name chunks created via `import()` or `System.import()`, and strip `.ngfactory` from the chunk name.

hansl pushed a commit that referenced this pull request Jul 10, 2017

feat(@angular/cli): allow chunk names for imports

fd52246

Followup to #6881 Also name chunks created via `import()` or `System.import()`, and strip `.ngfactory` from the chunk name.

hansl pushed a commit that referenced this pull request Jul 12, 2017

feat(@angular/cli): allow chunk names for imports

f8f4283

Followup to #6881 Also name chunks created via `import()` or `System.import()`, and strip `.ngfactory` from the chunk name.

filipesilva mentioned this pull request Jul 17, 2017

feat(@angular/cli): add flag to control chunk naming #7007

Merged

dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018

feat(@angular/cli): allow chunk names for imports

e4fad24

Followup to angular#6881 Also name chunks created via `import()` or `System.import()`, and strip `.ngfactory` from the chunk name.

angular-automatic-lock-bot bot unassigned Brocco Sep 12, 2019

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(@angular/cli): name lazy chunks #6881

feat(@angular/cli): name lazy chunks #6881

filipesilva commented Jul 4, 2017

hansl Jul 4, 2017

filipesilva Jul 4, 2017

hansl left a comment

angular-automatic-lock-bot bot commented Sep 12, 2019

feat(@angular/cli): name lazy chunks #6881

feat(@angular/cli): name lazy chunks #6881

Conversation

filipesilva commented Jul 4, 2017

hansl Jul 4, 2017

Choose a reason for hiding this comment

filipesilva Jul 4, 2017

Choose a reason for hiding this comment

hansl left a comment

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Sep 12, 2019