Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to extract-text-webpack-plugin@^3.0.0 dependency #7085

Closed

Conversation

smoke
Copy link
Contributor

@smoke smoke commented Jul 21, 2017

This pulls the fix for webpack-contrib/extract-text-webpack-plugin#529 which is showing whenever ng i18n capabilities are used the following warning DeprecationWarning: Chunk.modules is deprecated. Use Chunk.getNumberOfModules/mapModules/forEachModule/containsModule instead.

Also should probably fix #7078

@filipesilva
Copy link
Contributor

Heya, the real problem here is that we accidentally left the webpack 3.3 commit in 1.2.2. It shouldn't have been there. The issue where we're tracking this is #7078.

I'm closing the PR because this is not the right approach. We'll have to make a non-PR commit directly to the 1.2.x branch.

@smoke
Copy link
Contributor Author

smoke commented Jul 21, 2017

Ok, this makes sense thanks!

@smoke smoke deleted the update-extract-text-webpack-plugin-dependency branch July 22, 2017 06:08
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants