This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Jasmine needs to be listed as a framework
karma conf is now exported functions how embarrassing - now it really should work need ng-scenario for e2e tests need karma-junit-reporter trying without jasmine trying some other plugins adding jasmine in I will stab someone ng-scenario is probably needed trying adding karma-ng-scenario need a package.json to specify dev deps normalise quotes
- Loading branch information
1 parent
dab5676
commit 5307e33
5307e33There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this commit and its message?
5307e33There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eternalmatt - That is a very good question!! :-) I think this commit was the victim of a rebase, where its change was subsumed into a previous commit already and so when it is was re-committed there was basically nothing left here. It is a rather entertaining if somewhat confusing commit message. It is probably best to simply squash the commit altogether to avoid further confusion.
5307e33There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, I assumed the message was the result of some rebase tool, but was really confused why the result of the rebase was just removing one line in a file. And also how did it get to the point where @btford merged it?
Side question, why are all the commits in this project "authored" so long ago and only committed now? see https://github.com/angular/angular-phonecat/commits/master
IgorMinar authored 3 years ago
petebacondarwin committed 2 days ago
5307e33There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.