fix(numberFilter): fix rounding error edge case

Fix a number rounding error. Closes #7453 Closes #7478
angular · May 15, 2014 · 81d427b · 81d427b
1 parent a84344a
commit 81d427b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/ng/filter/filters.js b/src/ng/filter/filters.js
@@ -145,8 +145,8 @@ function formatNumber(number, pattern, groupSep, decimalSep, fractionSize) {
       fractionSize = Math.min(Math.max(pattern.minFrac, fractionLen), pattern.maxFrac);
     }
 
-    var pow = Math.pow(10, fractionSize);
-    number = Math.round(number * pow) / pow;
+    var pow = Math.pow(10, fractionSize + 1);
+    number = Math.floor(number * pow + 5) / pow;
     var fraction = ('' + number).split(DECIMAL_SEP);
     var whole = fraction[0];
     fraction = fraction[1] || '';

diff --git a/test/ng/filter/filtersSpec.js b/test/ng/filter/filtersSpec.js
@@ -150,6 +150,10 @@ describe('filters', function() {
       expect(number(1234.567, 0)).toEqual("1,235");
       expect(number(1234.567, 1)).toEqual("1,234.6");
       expect(number(1234.567, 2)).toEqual("1,234.57");
+      expect(number(1.255,    0)).toEqual("1");
+      expect(number(1.255,    1)).toEqual("1.3");
+      expect(number(1.255,    2)).toEqual("1.26");
+      expect(number(1.255,    3)).toEqual("1.255");
     });
 
     it('should filter exponentially large numbers', function() {