Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Commit

Permalink
fix(ngSrc): don't set src if value is empty string
Browse files Browse the repository at this point in the history
Current implementation of ngSrc may lead to empty src attribute when page is loading.

For example:

<img ng-src="{{image.url}}">
can be temporarily rendered as

<img src="">
before the image resource is loaded.

Some browser emits a request to the current page when seeing <img src=""> (Firefox13 and IE8 will, Chromium20 won't), which leads to performance problems.
  • Loading branch information
xrchen authored and mhevery committed Sep 6, 2012
1 parent d9eff86 commit b6e4a71
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/ng/directive/booleanAttrs.js
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,9 @@ forEach(['src', 'href'], function(attrName) {
priority: 99, // it needs to run after the attributes are interpolated
link: function(scope, element, attr) {
attr.$observe(normalized, function(value) {
if (!value)
return;

attr.$set(attrName, value);

// on IE, if "ng:src" directive declaration is used and "src" attribute doesn't exist
Expand Down
17 changes: 17 additions & 0 deletions test/ng/directive/ngSrcSpec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
'use strict';

describe('ngSrc', function() {
var element;

afterEach(function() {
dealoc(element);
});

it('should not result empty string in img src', inject(function($rootScope, $compile) {
$rootScope.image = {};
element = $compile('<img ng-src="{{image.url}}">')($rootScope);
$rootScope.$digest();
expect(element.attr('src')).not.toBe('');
expect(element.attr('src')).toBe(undefined);
}));
});

0 comments on commit b6e4a71

Please sign in to comment.