bug(equals): incorect comparison of dates

angular · Feb 23, 2012 · ffa8441 · ffa8441
1 parent 5d8528c
commit ffa8441
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/Angular.js b/src/Angular.js
@@ -671,6 +671,8 @@ function equals(o1, o2) {
           }
           return true;
         }
+      } else if (isDate(o1)) {
+        return isDate(o2) && o1.getTime() == o2.getTime();
       } else {
         if (isScope(o1) || isScope(o2) || isWindow(o1) || isWindow(o2)) return false;
         keySet = {};

diff --git a/test/AngularSpec.js b/test/AngularSpec.js
@@ -168,6 +168,13 @@ describe('angular', function() {
       expect(equals(window, window.parent)).toBe(false);
       expect(equals(window, undefined)).toBe(false);
     });
+
+    it('should compare dates', function() {
+      expect(equals(new Date(0), new Date(0))).toBe(true);
+      expect(equals(new Date(0), new Date(1))).toBe(false);
+      expect(equals(new Date(0), 0)).toBe(false);
+      expect(equals(0, new Date(0))).toBe(false);
+    });
   });
 
   describe('size', function() {