You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
With the new animation system, if you have ngHide and ngClass on the same element, animations stop working (it might happen with other combinations too). Look at this plunker:
This is a plunker from the yearofmoo article on the animation system in 1.2.0. All I did was add a ngClass directive on this and the animations no longer play. This is happening in 1.2.0rc1 and I also tested it against the code the include the patch for this issue : #3587 : and both of them show the issue. If you remove the ngClass directive on the element, the animation works fine.
The text was updated successfully, but these errors were encountered:
ngShow and ngHide work the same way as ngClass in 1.2 -- they both add and remove the ng-hide class. And when ngAnimate detects an animation on the same element where another animation is ongoing then it cancels the first animation in favour of the next animation. What's going on here is that ngShow/ngHide gets triggered and starts to do it's animation work, but then ngClass gets evaluated and tells animator to add the active class which cancels out the show/hide animation.
This is expected behaviour, but I can see how it should work different. Ideally ngClass should only animate and cancel out an ongoing animation if it's CSS class styling has a transition/animation property present on it. I'll look into doing this.
With the new animation system, if you have ngHide and ngClass on the same element, animations stop working (it might happen with other combinations too). Look at this plunker:
http://plnkr.co/edit/bzaQJVUvlx4BhFaAN88j?p=preview
This is a plunker from the yearofmoo article on the animation system in 1.2.0. All I did was add a ngClass directive on this and the animations no longer play. This is happening in 1.2.0rc1 and I also tested it against the code the include the patch for this issue : #3587 : and both of them show the issue. If you remove the ngClass directive on the element, the animation works fine.
The text was updated successfully, but these errors were encountered: