Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

[Chrome for Android] slowness and broken binding #5323

Closed
learningjs opened this issue Dec 8, 2013 · 8 comments
Closed

[Chrome for Android] slowness and broken binding #5323

learningjs opened this issue Dec 8, 2013 · 8 comments

Comments

@learningjs
Copy link

A couple days ago I opened an issue for mobile-chrome-apps .

Testing a basic Mobile Chrome App with angularjs , I have experienced a noticeable lag between the typing in an input text and the output ; between a click on a button or a link and the output in a test tag showing the result of an operation ; some times when typing nothing happened , etc .

Then I tried some simple code in web pages and again I have experienced the same issues testing with Chrome for Android ( beta and stable ) .

No issue testing with Firefox , Dolphin , etc .

Long story short , if I am not wrong , this is something related with angularjs versions 1.2.2 , 1.2.3 and 1.2.4 and only affecting Chrome for Android - and Mobile Chrome Apps - ( no Chrome per desktop or other mobile browsers ) .

angularjs version 1.2.1 is not affected by those issues at all and Chrome for Android behaves normally ( for what I tested ) .

Tested on Samsung Note 2 and Galaxy Tab 2 7.0 with Android 4.1.2

@ghost ghost assigned jeffbcross Dec 8, 2013
@jeffbcross
Copy link
Contributor

Hi @learningjs can you create a simplified plunker that can be used to reproduce the issue?

@learningjs
Copy link
Author

Affected by broken binding issue

angularjs V1.2.4
angularjs V1.2.3
angularjs V1.2.2

Not affected

angularjs V1.2.1

Interesting enough , after the last Chrome for Android update ( I guess , or something changed with the angularjs affected versions ? ) , seems that things have changed : I am unable to reproduce the original lag ( now tested only web pages , no Mobile Chrome Apps ) , but now I experience the broken binding ( previously not experienced ) :

Original code that lead to the issue

  • before the text input ( and both the button and the link ) generated a noticeable lag ( specially the link ) . Now only the text input is affected by the new broken binding issue .

Note : I have experienced these issues on Samsung Note 2 and Galaxy Tab 2 7.0 with Android 4.1.2 . As per a comment in the Mobile Chrome Apps issue other devices were not affected by slowness or broken binding using new version of angularjs ( I do not know if tested also for the specific issue that I opened ) .

@learningjs
Copy link
Author

Same issue with angularjs V1.2.5 .

@caitp
Copy link
Contributor

caitp commented Dec 14, 2013

#5308 --- It should be noted that the cause of this is already known input.js#L409

It seems that not waiting for compositionend is a problem for many IMEs, particularly things like CJK language IMEs, but is a problem due to buggy IMEs not emitting events when we would like them to. I'm not sure it makes sense to try to fix this "in angular", since we can't really tell what IME we're dealing with.

We might be able to make use of CompositionEvent.data or something, I'll try some experiments I guess

clkao added a commit to clkao/angular.js that referenced this issue Dec 18, 2013
Workaround for chrome for android until angular#2129 is ready.

Closes angular#5308, angular#5323
tbosch pushed a commit that referenced this issue Dec 18, 2013
Workaround for chrome for android until #2129 is ready.

Closes #5308, #5323
@learningjs
Copy link
Author

To emphasize it , I experienced this issue only with Chrome on Samsung devices . Other browsers are not affected on the same devices . I am just curious ... Can someone please point out if the issue affected also other browsers / devices ?

@clkao
Copy link
Contributor

clkao commented Dec 31, 2013

This is fixed in 1.2.6 and should have been closed along with #5308. The root cause is that chrome on latest android (when autocomplete-enabled input is in use) firing composition events differently. We are now ignoring composition events all together (the 1.2.1 behaviour) on android until later.

@learningjs
Copy link
Author

Thanks for the support and fix .

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
@tbosch
Copy link
Contributor

tbosch commented Feb 12, 2014

Closing this as @clkao suggested

@tbosch tbosch closed this as completed Feb 12, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants