Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

ngResource: '$' in pamater values are not escaped properly #6003

Closed
tam4s opened this issue Jan 27, 2014 · 1 comment
Closed

ngResource: '$' in pamater values are not escaped properly #6003

tam4s opened this issue Jan 27, 2014 · 1 comment
Labels
component: ngResource
Milestone
1.2.11

Comments

@tam4s
Copy link

tam4s commented Jan 27, 2014

1 liner demonstration in a browser JS console:

angular.injector(['ngResource']).get('$resource')('/search/:str').get({'str': 'hello$'})
GET http://docs.angularjs.org/search/hello$1 404 (Not Found)

Notice the extra '1' in the URL.
caitp added a commit to caitp/angular.js that referenced this issue Jan 27, 2014
@caitp
fix(ngResource): don't append number to '$' in url param value when e…
f7cefcb 
…ncoding URI

Previously, if a URL parameter value included a $, it would replace the dollar sign with a literal
'$1' for mysterious reasons. Using a function rather than a replacement string circumvents this
behaviour and produces a more expected result.

Closes angular#6003
@caitp caitp mentioned this issue Jan 27, 2014
Closed
@caitp
Copy link
Contributor

caitp commented Jan 27, 2014

Interesting, I've taken a stab at correcting this, would you care to try my patch and see if it introduces any regressions not caught by the tests?

@ghost ghost assigned vojtajina Jan 28, 2014
caitp added a commit to caitp/angular.js that referenced this issue Feb 3, 2014
@caitp
fix(ngResource): don't append number to '$' in url param value when e…
750a80b 
…ncoding URI

Previously, if a URL parameter value included a $, it would replace the dollar sign with a literal
'$1' for mysterious reasons. Using a function rather than a replacement string circumvents this
behaviour and produces a more expected result.

Closes angular#6003
caitp added a commit to caitp/angular.js that referenced this issue Feb 3, 2014
@caitp
fix(ngResource): don't append number to '$' in url param value when e…
2b7e9db 
…ncoding URI

Previously, if a URL parameter value included a $, it would replace the dollar sign with a literal
'$1' for mysterious reasons. Using a function rather than a replacement string circumvents this
behaviour and produces a more expected result.

Closes angular#6003
@caitp caitp closed this as completed in ce1f1f9 Feb 3, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: ngResource
Projects
None yet
Milestone
1.2.11
Development

Successfully merging a pull request may close this issue.

fix(ngResource): don't append number to '$' in url param value when encoding URI caitp/angular.js
3 participants
@vojtajina @tam4s @caitp