Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Bug: angular.contents() not working with iframes #6320

Closed
nervgh opened this issue Feb 18, 2014 · 4 comments
Closed

Bug: angular.contents() not working with iframes #6320

nervgh opened this issue Feb 18, 2014 · 4 comments
Assignees
@caitp
Labels
component: jqLite frequency: low type: bug
Milestone
1.2.14

Comments

@nervgh
Copy link

nervgh commented Feb 18, 2014

Hi

Please, fix the angular.contents() method.

angular last version
https://github.com/angular/angular.js/blob/master/src/jqLite.js#L795

jquery 1.8.3
https://github.com/jquery/jquery/blob/1.8.3/src/traversing.js#L198
@caitp
Copy link
Contributor

caitp commented Feb 18, 2014

I'll submit a patch for this, but is there any reason you don't just use jQuery if you need this?

@nervgh nervgh mentioned this issue Feb 18, 2014
Closed
@nervgh
Copy link
Author

nervgh commented Feb 18, 2014

I'll submit a patch for this, but is there any reason you don't just use jQuery if you need this?

Thanks! Remove the jquery dependency for my uploader =)
https://github.com/nervgh/angular-file-upload/blob/master/src/scripts/services/%24fileUploader.js#L372
https://github.com/nervgh/angular-file-upload

caitp added a commit to caitp/angular.js that referenced this issue Feb 18, 2014
@caitp
fix(jqLite): make jqLite('<iframe src="someurl">').contents() return …
e542cf0 
…iframe document, as in jQuery

This is a very tiny change to make behaviour consistent with jQuery.

Closes angular#6320
@caitp caitp mentioned this issue Feb 18, 2014
Closed
caitp added a commit to caitp/angular.js that referenced this issue Feb 18, 2014
@caitp
fix(jqLite): make jqLite('<iframe src="someurl">').contents() return …
9ea67e1 
…iframe document, as in jQuery

This is a very tiny change to make behaviour consistent with jQuery.

Closes angular#6320
caitp added a commit to caitp/angular.js that referenced this issue Feb 18, 2014
@caitp
fix(jqLite): make jqLite('<iframe src="someurl">').contents() return …
90800c8 
…iframe document, as in jQuery

This is a very tiny change to make behaviour consistent with jQuery.

Closes angular#6320
caitp added a commit to caitp/angular.js that referenced this issue Feb 18, 2014
@caitp
fix(jqLite): make jqLite('<iframe src="someurl">').contents() return …
bc25a36 
…iframe document, as in jQuery

This is a very tiny change to make behaviour consistent with jQuery.

Closes angular#6320
caitp added a commit to caitp/angular.js that referenced this issue Feb 18, 2014
@caitp
fix(jqLite): make jqLite('<iframe src="someurl">').contents() return …
e91b6c3 
…iframe document, as in jQuery

This is a very tiny change to make behaviour consistent with jQuery.

Closes angular#6320
caitp added a commit to caitp/angular.js that referenced this issue Feb 18, 2014
@caitp
fix(jqLite): make jqLite('<iframe src="someurl">').contents() return …
de2717c 
…iframe document, as in jQuery

This is a very tiny change to make behaviour consistent with jQuery.

Closes angular#6320
@caitp
Copy link
Contributor

caitp commented Feb 18, 2014

I think this might have to wait for 1.3, because unfortunately IE8 is being a major pain. Everything else is happy, though. Sorry about the commit spam ^^

caitp added a commit to caitp/angular.js that referenced this issue Feb 18, 2014
@caitp
fix(jqLite): make jqLite('<iframe src="someurl">').contents() return …
8a8bad1 
…iframe document, as in jQuery

This is a very tiny change to make behaviour consistent with jQuery.

Closes angular#6320
@IgorMinar IgorMinar added this to the 1.2.14 milestone Feb 18, 2014
@caitp caitp closed this as completed in 05fbed5 Feb 18, 2014
@nervgh
Copy link
Author

nervgh commented Feb 19, 2014

Sorry about the commit spam

😄

Thanks!

khepin pushed a commit to khepin/angular.js that referenced this issue Feb 19, 2014
@caitp
fix(jqLite): make jqLite('<iframe src="someurl">').contents() return …
6eee0a0 
…iframe document, as in jQuery

This is a very tiny change to make behaviour consistent with jQuery.

Closes angular#6320
Closes angular#6323
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@caitp caitp

Labels
component: jqLite frequency: low type: bug
Projects
None yet
Milestone
1.2.14
3 participants
@IgorMinar @caitp @nervgh