Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Let $swipe ignore mouse movement #6626

Closed
OleMchls opened this issue Mar 9, 2014 · 29 comments · Fixed by #7467
Closed

Let $swipe ignore mouse movement #6626

OleMchls opened this issue Mar 9, 2014 · 29 comments · Fixed by #7467
Assignees
@tbosch
Labels
component: ngTouch frequency: low needs: public api severity: inconvenient type: feature
Milestone
Backlog - won't fix

Comments

@OleMchls
Copy link
Contributor

OleMchls commented Mar 9, 2014

Hey everyone,

I have a usecase where the swipeable area also contains some text which the user might want to select. But when I now have the $swipe directive in place. When ever I select text the directive triggers the swipe event.

So please give me the choice to deactivate it

❤️ ❤️ ❤️

P.S. Only the bravest heros are going to implement this 👯
@robinboehm robinboehm mentioned this issue Mar 9, 2014
Closed
@btford btford added this to the Backlog milestone Mar 17, 2014
@btford
Copy link
Contributor

btford commented Mar 17, 2014

Only the bravest heros are going to implement this

😆

@btford
Copy link
Contributor

btford commented Mar 17, 2014

Pinging animation expert™ @matsko and mobile expert™ @tbosch. Ideas?

@tbosch
Copy link
Contributor

tbosch commented Mar 17, 2014

Sounds reasonable to me.

@OleMchls
Copy link
Contributor Author

Any incidents missing that we (I) could add besides patience? 🎰

@tbosch tbosch self-assigned this Mar 21, 2014
@tbosch tbosch modified the milestones: 1.3.0-beta.3, Backlog Mar 21, 2014
@tbosch
Copy link
Contributor

tbosch commented Mar 21, 2014

Try to merge next week...

@btford btford modified the milestones: 1.3.0-beta.4, 1.3.0-beta.3 Mar 24, 2014
@OleMchls
Copy link
Contributor Author

🎈🎈🎈🎈🎈 Just some motivational 🎈's

🚂.🚋.🚋.🚋.🚋.🚋 choooot choot

@tbosch tbosch modified the milestones: Backlog, 1.3.0-beta.5 Mar 31, 2014
@OleMchls
Copy link
Contributor Author

Any updates on this? :)

@btford btford mentioned this issue Apr 21, 2014
Closed
@dvberkel
Copy link

dvberkel commented May 8, 2014

👍

@justechn
Copy link

whats the status of this?

@robinboehm
Copy link
Contributor

Really need this +1
Impl done here: #6627

@tmhpfnr
Copy link

tmhpfnr commented May 14, 2014

+1

1 similar comment
@walski
Copy link

walski commented May 14, 2014

👍

@joscha
Copy link
Contributor

joscha commented May 14, 2014

👍

6 similar comments
@lassediercks
Copy link

👍

@bastiank
Copy link

👍

@sbrink
Copy link

sbrink commented May 14, 2014

👍

@justphil
Copy link

👍

@Lukewa
Copy link

Lukewa commented May 14, 2014

👍

@frankbo
Copy link

frankbo commented May 14, 2014

👍

@elmarburke
Copy link

Yea! 👍

@m4r71n
Copy link

m4r71n commented May 14, 2014

👍

tbosch pushed a commit to tbosch/angular.js that referenced this issue May 14, 2014
@robinboehm @tbosch
feat(ngTouch): add optional ngSwipeDisableMouse attribute to `ngSwi…
a019f36 
…pe` directives to ignore mouse events.

This attribute is useful for text that should still be selectable
by the mouse and not trigger the swipe action.

This also adds an optional third argument to `$swipe.bind` to define
the pointer types that should be listened to.

Closes angular#6627
Fixes angular#6626
@tbosch tbosch mentioned this issue May 14, 2014
Merged
tbosch pushed a commit to tbosch/angular.js that referenced this issue May 14, 2014
@robinboehm @tbosch
feat(ngTouch): add optional ngSwipeDisableMouse attribute to `ngSwi…
3deb458 
…pe` directives to ignore mouse events.

This attribute is useful for text that should still be selectable
by the mouse and not trigger the swipe action.

This also adds an optional third argument to `$swipe.bind` to define
the pointer types that should be listened to.

Closes angular#6627
Fixes angular#6626
tbosch pushed a commit to tbosch/angular.js that referenced this issue May 14, 2014
@robinboehm @tbosch
feat(ngTouch): add optional ngSwipeDisableMouse attribute to `ngSwi…
5a568b4 
…pe` directives to ignore mouse events.

This attribute is useful for text that should still be selectable
by the mouse and not trigger the swipe action.

This also adds an optional third argument to `$swipe.bind` to define
the pointer types that should be listened to.

Closes angular#6627
Fixes angular#6626
@robinboehm
Copy link
Contributor

Thx 👍

@OleMchls
Copy link
Contributor Author

Awesome! Thanks a bunch!

@jstrength jstrength mentioned this issue Jul 25, 2014
Closed
@ExceptionCaught
Copy link

👍 Just on time.

@robertu7
Copy link

+1

@spietra
Copy link

spietra commented Apr 21, 2015

Hi everybody,
I'm really new, can you please give me an example on how use the ngSwipeDisableMouse? Thanks

@tmhpfnr
Copy link

tmhpfnr commented Apr 21, 2015

@spietra Like the documentation states you just need to

add ng-swipe-disable-mouse to the ng-swipe-left or ng-swipe-right DOM Element.

@SubZero-0
Copy link

Hi all, I use ng-swipe-disable-mouse and it's really works great for ng-swipe-left & ng-swipe-right
but what can I do with ng-swipe-up or ng-swipe-down?

@juanvillegas
Copy link

@tmhpfnr its funny because that doc statement technically doesn't make any sense. ng-swipe-left/ng-swipe-right is not a DOM element..

@bjarnef bjarnef mentioned this issue Mar 14, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tbosch tbosch

Labels
component: ngTouch frequency: low needs: public api severity: inconvenient type: feature
Projects
None yet
Milestone
Backlog - won't fix
Development

Successfully merging a pull request may close this issue.

feat(ngTouch): add optional ngSwipeDisableMouse attribute to ngSwipe... tbosch/angular.js