Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Multiple invocations of angular.mock.module(obj) are ignored #7254

Closed
shahata opened this issue Apr 25, 2014 · 1 comment
Closed

Multiple invocations of angular.mock.module(obj) are ignored #7254

shahata opened this issue Apr 25, 2014 · 1 comment

Comments

@shahata
Copy link
Contributor

shahata commented Apr 25, 2014

Currently if I invoke angular.mock.module() with an object param, only the first invocation works and all the rest are ignored. http://plnkr.co/edit/HIuhaIfPpPKWjwC5xFBf?p=preview
@shahata shahata mentioned this issue Apr 25, 2014
Closed
caitp pushed a commit to caitp/angular.js that referenced this issue Jun 8, 2014
@shahata @caitp
fix(injector): allow multiple loading of function modules
b7ea399 
move the loadedModules lookup to be performed only on strings in order to allow loading functions that look the same. this issue caused only the first `angular.mock.module(object)` invocation to work since the loadModules lookup blocked all following invocations.

closes angular#7254
caitp pushed a commit to caitp/angular.js that referenced this issue Jun 8, 2014
@shahata @caitp
fix(injector): allow multiple loading of function modules
3bd94d3 
move the loadedModules lookup to be performed only on strings in order to allow loading functions that look the same. this issue caused only the first `angular.mock.module(object)` invocation to work since the loadModules lookup blocked all following invocations.

closes angular#7254
@Narretz
Copy link
Contributor

Narretz commented Jul 1, 2014

fixed in 2f0a448

@Narretz Narretz closed this as completed Jul 1, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(injector): allow multiple loading of function modules
2 participants
@Narretz @shahata