Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix($browser): should use first value for a cookie. #2636

Merged
merged 1 commit into from
May 12, 2013

Conversation

chirayuk
Copy link
Contributor

With this change, $browser.cookies()["foo"] will behave like
docCookies.getItem("foo") where docCookies is defined at
https://developer.mozilla.org/en-US/docs/DOM/document.cookie

Ref: #2635

This fixes the issue where, if there's a value for the XSRF-TOKEN cookie
value with the path /, then that value is used for all applications in
the domain even if they set path specific values for XSRF-TOKEN.

@ghost ghost assigned IgorMinar May 11, 2013
With this change, $browser.cookies()["foo"] will behave like
docCookies.getItem("foo") where docCookies is defined at
https://developer.mozilla.org/en-US/docs/DOM/document.cookie

This fixes the issue where, if there's a value for the XSRF-TOKEN cookie
value with the path /, then that value is used for all applications in
the domain even if they set path specific values for XSRF-TOKEN.

Closes angular#2635
@chirayuk
Copy link
Contributor Author

Thanks Igor! I've addressed the comments and updated the commit. I'll merge this in later this evening or tomorrow morning.

@chirayuk chirayuk merged commit 3952d35 into angular:master May 12, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants