fix(angular.equals): regular expressions are never considered equal #2715
Conversation
Regular expression objects are never considered to be equal when using 'angular.equals'. Dirty checking therefore fails to recognize a property modification. Closes #2685
|
@bripkens - you have two things going on here. A "fix" for angular.equals and a "feature" for the new isRegExp function. Can you split this PR into two separate ones, with separate commits. Once you have done that please ensure that you have signed the CLA if you haven't already - see http://docs.angularjs.org/misc/contribute. |
|
The E2E tests keep timing out but I think this is an issue with the CI server rather than this patch: http://ci.angularjs.org/job/angular.js-pete/174/console |
|
Tried it again (locally) and did not run into any issues, so I would concur that his an issue with Jenkins, but of course I can understand your wish to verify this yourself :-). |
|
what happened here? I don't think that this fix got merged. I'm closing #2729 in favor of this fix since this fix contains changes to we need to change this as to not expose the utility fn as public api (please make sure that the |
|
nevermind. I merged this in as commits referenced from #2729 |
Regular expression objects are never considered to be equal when using
'angular.equals'. Dirty checking therefore fails to recognize a
property modification.
Closes #2685