This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Fix unit test in IE7 #360
Closed
Fix unit test in IE7 #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just for future info, the one test which is not executed on IE is not an issue, as there is a condition to run the test only if not IE browser: |
|
angular.js: master Vojta Jina * aa64d37 (3 files in 2 dirs): Fix unit test in IE7 - http://bit.ly/jCfSH5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes 2 tests in IE7, so now all tests pass in IE7, IE8 on my machine.
Unfortunately there is still one test, that is even not executed in IE - there are 810 tests executed in Chrome / FF / Opera, but only 809 tests in IE7 / IE8.
That's problem of JSTD, it silently ignore tests with syntax errors:
http://code.google.com/p/js-test-driver/issues/detail?id=21