Fix for event.stopPropagation() and $emit method

[stsvilik]

This fix addresses an issue where event.stopPropagation() prematurely ends execution of event listeners assigned to the same scope from which they are $emit-ted.

For example you assign 2 listeners to the same scope:
a)

scope.on('myEvent', function(evt) {
  evt.stopPropagation();
  //Do something
});

b) Somewhere else on the same scope, perhaps inside other directive or controller

scope.on('myEvent', function(evt) {
  //Do something else
});

Currently handler in 'a' will prevent handler 'b' from executing even though they are on the same exact scope, but this is not the intention of the stopPropagation() function. Intention is to prevent 'myEvent' from bubbling into $parent scope.

If we take jQuery or just plain DOM eventing model, we'll see that stopPropagation does NOT prevent multiple handlers that are attached to the same node from firing.

[mary-poppins]

Thanks for the PR!

• Contributor signed CLA now or in the past
  • If you just signed, leave a comment here with your real name
• PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

[stsvilik]

CLA signed, I tried to clean-up my pull request history but not sure if it worked :/. Github blows when it comes to cherry-picking what you want to PULL. So for clarification sake, my pull should only be for c0c5d8e.

[btford]

This PR is a mess, but the final diff looks ok.

[stsvilik]

Agreed (re:mess) this was due to some old PR's that were done w/o following formal commit instructions (sorry for that), so I had to revert them. It also took me a while to get into the PR procedure flow. I promise it will not happen again.

[btford]

It's ok. Just rebase and squash them (see git rebase -i) please. :)

[stsvilik]

When now? :) or you talking about the future PR's?

[btford]

For this one, as well as in the future. :)

[btford]

whoops, wrong thread. ignore me :)

[btford]

I'm going to close this for now due to inactivity. If you can rebase against master and clean up the commit history, I'd be happy to re-open this.

[stsvilik]

Brian I had to start from the very beginning. Please refer to the new pull request I created: #4204

Thank You